Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflow): fix summary count error #3628

Merged
merged 1 commit into from
Feb 7, 2023
Merged

ci(workflow): fix summary count error #3628

merged 1 commit into from
Feb 7, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Feb 3, 2023

Minor fix for calculation error.

@kwonoj kwonoj requested review from a team as code owners February 3, 2023 20:15
@vercel
Copy link

vercel bot commented Feb 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 8:16PM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 8:16PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 8:16PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 3, 2023 at 8:16PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 3, 2023 at 8:16PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 8:16PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 3, 2023 at 8:16PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 8:16PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 8:16PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 3, 2023 at 8:16PM (UTC)

Copy link
Member

@ForsakenHarmony ForsakenHarmony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add this action to the codeowners file

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Failing next.js integration test suites

Commit: 689f899

Test summary

main (6e5a2c9 / v13.1.7-canary.4) Current (689f899 / v13.1.7-canary.4) Diff (Failed)
Test suites 🔴 12 / 🟢 0 (Total: 12) 🔴 12 / 🟢 0 (Total: 12) 0️⃣
Test cases 🔴 36 / 🟢 12 (Total: 50) 🔴 36 / 🟢 20 (Total: 58) 0️⃣

Fixed tests:

- test/integration/broken-webpack-plugin/test/index.test.js 
- test/integration/broken-webpack-plugin/test/index.test.js

Newly failed tests:

- test/integration/404-page-app/test/index.test.js 
- test/integration/404-page-app/test/index.test.js
Full test report

test/development/acceptance-app/component-stack.test.ts

  • Component Stack in error overlay > should show a component stack on hydration error
Expand output

● Component Stack in error overlay › should show a component stack on hydration error

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('[data-nextjs-toast]')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

test/e2e/edge-compiler-can-import-blob-assets/index.test.ts

  • Edge Compiler can import asset assets > allows to fetch a remote URL
  • Edge Compiler can import asset assets > allows to fetch a remote URL with a path and basename
  • Edge Compiler can import asset assets > allows to fetch text assets
  • Edge Compiler can import asset assets > allows to fetch image assets
  • Edge Compiler can import asset assets > allows to assets from node_modules
  • Edge Compiler can import asset assets > extracts all the assets from the bundle
Expand output

● Edge Compiler can import asset assets › allows to fetch a remote URL

expect(received).toContain(expected) // indexOf

Expected substring: "Example Domain"
Received string:    "Execution of get_from_source failed·
Caused by:
    0: Execution of resolve_source_request failed
    1: Execution of CombinedContentSource::get failed
    2: Execution of create_app_source failed
    3: Execution of load_next_config failed
    4: Execution of evaluate failed
    5: Execution of get_evaluate_pool failed
    6: Execution of turbo_tasks::completion::CompletionsVc::all failed
    7: Execution of turbopack_core::asset::AssetContentVc::write failed
    8: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::content failed
    9: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::code failed
   10: Execution of content_from_relative_path failed
   11: failed to canonicalize embedded file path
   12: No such file or directory (os error 2)"

  27 |       handler: 'remote-full',
  28 |     })
> 29 |     expect(await response.text()).toContain('Example Domain')
     |                                   ^
  30 |   })
  31 |
  32 |   it('allows to fetch a remote URL with a path and basename', async () => {

  at Object.<anonymous> (e2e/edge-compiler-can-import-blob-assets/index.test.ts:29:35)

● Edge Compiler can import asset assets › allows to fetch a remote URL with a path and basename

expect(received).toContain(expected) // indexOf

Expected substring: "Example Domain"
Received string:    "Execution of get_from_source failed·
Caused by:
    0: Execution of resolve_source_request failed
    1: Execution of CombinedContentSource::get failed
    2: Execution of create_app_source failed
    3: Execution of load_next_config failed
    4: Execution of evaluate failed
    5: Execution of get_evaluate_pool failed
    6: Execution of turbo_tasks::completion::CompletionsVc::all failed
    7: Execution of turbopack_core::asset::AssetContentVc::write failed
    8: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::content failed
    9: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::code failed
   10: Execution of content_from_relative_path failed
   11: failed to canonicalize embedded file path
   12: No such file or directory (os error 2)"

  41 |       }
  42 |     )
> 43 |     expect(await response.text()).toContain('Example Domain')
     |                                   ^
  44 |   })
  45 |
  46 |   it('allows to fetch text assets', async () => {

  at Object.<anonymous> (e2e/edge-compiler-can-import-blob-assets/index.test.ts:43:35)

● Edge Compiler can import asset assets › allows to fetch text assets

expect(received).toContain(expected) // indexOf

Expected substring: "Hello, from text-file.txt!"
Received string:    "Execution of get_from_source failed·
Caused by:
    0: Execution of resolve_source_request failed
    1: Execution of CombinedContentSource::get failed
    2: Execution of create_app_source failed
    3: Execution of load_next_config failed
    4: Execution of evaluate failed
    5: Execution of get_evaluate_pool failed
    6: Execution of turbo_tasks::completion::CompletionsVc::all failed
    7: Execution of turbopack_core::asset::AssetContentVc::write failed
    8: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::content failed
    9: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::code failed
   10: Execution of content_from_relative_path failed
   11: failed to canonicalize embedded file path
   12: No such file or directory (os error 2)"

  48 |       handler: 'text-file',
  49 |     })
> 50 |     expect(html).toContain('Hello, from text-file.txt!')
     |                  ^
  51 |   })
  52 |
  53 |   it('allows to fetch image assets', async () => {

  at Object.<anonymous> (e2e/edge-compiler-can-import-blob-assets/index.test.ts:50:18)

● Edge Compiler can import asset assets › allows to fetch image assets

expect(received).toBeTrue()

Expected value to be true:
  true
Received:
  false

  59 |       path.join(__dirname, './app/src/vercel.png')
  60 |     )
> 61 |     expect(buffer.equals(image)).toBeTrue()
     |                                  ^
  62 |   })
  63 |
  64 |   it('allows to assets from node_modules', async () => {

  at Object.<anonymous> (e2e/edge-compiler-can-import-blob-assets/index.test.ts:61:34)

● Edge Compiler can import asset assets › allows to assets from node_modules

FetchError: invalid json response body at http://localhost:38927/api/edge?handler=from-node-module reason: Unexpected token E in JSON at position 0

  66 |       handler: 'from-node-module',
  67 |     })
> 68 |     const json = await response.json()
     |                  ^
  69 |     expect(json).toEqual({
  70 |       'i am': 'a node dependency',
  71 |     })

  at ../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:273:32
  at Object.<anonymous> (e2e/edge-compiler-can-import-blob-assets/index.test.ts:68:18)

● Edge Compiler can import asset assets › extracts all the assets from the bundle

ENOENT: no such file or directory, open '/tmp/next-install-535f4f9ab59f0354163326385c99b88cc0005037d508f03b800d8ee45b0ead86/.next/server/middleware-manifest.json'

test/integration/404-page-app/test/index.test.js

  • 404 Page Support with _app > dev mode > should not show pages/404 GIP error if _app has GIP
Expand output

● 404 Page Support with _app › dev mode › should not show pages/404 GIP error if _app has GIP

expect(received).toBe(expected) // Object.is equality

Expected: 404
Received: 500

  79 |     it('should not show pages/404 GIP error if _app has GIP', async () => {
  80 |       const res = await fetchViaHTTP(appPort, '/abc')
> 81 |       expect(res.status).toBe(404)
     |                          ^
  82 |       const $ = cheerio.load(await res.text())
  83 |       expect($('#404-title').text()).toBe('Hi There')
  84 |       expect(stderr).not.toMatch(gip404Err)

  at Object.<anonymous> (integration/404-page-app/test/index.test.js:81:26)

test/development/api-cors-with-rewrite/index.test.ts

  • Rewritten API Requests should pass OPTIONS requests to the api function > should pass OPTIONS requests to the api function
Expand output

● Rewritten API Requests should pass OPTIONS requests to the api function › should pass OPTIONS requests to the api function

expect(received).toContain(expected) // indexOf

Expected substring: "successfully hit some-endpoint!"
Received string:    "Execution of get_from_source failed·
Caused by:
    0: Execution of resolve_source_request failed
    1: Execution of CombinedContentSource::get failed
    2: Execution of create_app_source failed
    3: Execution of load_next_config failed
    4: Execution of evaluate failed
    5: Execution of get_evaluate_pool failed
    6: Execution of turbo_tasks::completion::CompletionsVc::all failed
    7: Execution of turbopack_core::asset::AssetContentVc::write failed
    8: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::content failed
    9: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::code failed
   10: Execution of content_from_relative_path failed
   11: failed to canonicalize embedded file path
   12: No such file or directory (os error 2)"

  41 |       },
  42 |     })
> 43 |     expect(await res.text()).toContain('successfully hit some-endpoint!')
     |                              ^
  44 |   })
  45 | })
  46 |

  at Object.<anonymous> (development/api-cors-with-rewrite/index.test.ts:43:30)

test/e2e/app-dir/app-rendering/rendering.test.ts

  • app dir rendering > should serve app/page.server.js at /
  • app dir rendering > ISR > should revalidate the page when revalidate is configured
  • app dir rendering > SSR only > should run data in layout and page
  • app dir rendering > SSR only > should run data fetch in parallel
  • app dir rendering > static only > should run data in layout and page
  • app dir rendering > static only > should run data in parallel during development
Expand output

● app dir rendering › should serve app/page.server.js at /

expect(received).toContain(expected) // indexOf

Expected substring: "app/page.server.js"
Received string:    "Execution of get_from_source failed·
Caused by:
    0: Execution of resolve_source_request failed
    1: Execution of CombinedContentSource::get failed
    2: Execution of create_app_source failed
    3: Execution of load_next_config failed
    4: Execution of evaluate failed
    5: Execution of get_evaluate_pool failed
    6: Execution of turbo_tasks::completion::CompletionsVc::all failed
    7: Execution of turbopack_core::asset::AssetContentVc::write failed
    8: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::content failed
    9: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::code failed
   10: Execution of content_from_relative_path failed
   11: failed to canonicalize embedded file path
   12: No such file or directory (os error 2)"

  12 |     it('should serve app/page.server.js at /', async () => {
  13 |       const html = await next.render('/')
> 14 |       expect(html).toContain('app/page.server.js')
     |                    ^
  15 |     })
  16 |
  17 |     describe('SSR only', () => {

  at Object.<anonymous> (e2e/app-dir/app-rendering/rendering.test.ts:14:20)

● app dir rendering › SSR only › should run data in layout and page

expect(received).toBe(expected) // Object.is equality

Expected: "hello from layout"
Received: ""

  18 |       it('should run data in layout and page', async () => {
  19 |         const $ = await next.render$('/ssr-only/nested')
> 20 |         expect($('#layout-message').text()).toBe('hello from layout')
     |                                             ^
  21 |         expect($('#page-message').text()).toBe('hello from page')
  22 |       })
  23 |

  at Object.<anonymous> (e2e/app-dir/app-rendering/rendering.test.ts:20:45)

● app dir rendering › SSR only › should run data fetch in parallel

expect(received).toBe(expected) // Object.is equality

Expected: "hello from slow layout"
Received: ""

  30 |         // Using 7 seconds to ensure external factors causing slight slowness don't fail the tests
  31 |         expect(duration < 7000).toBe(true)
> 32 |         expect($('#slow-layout-message').text()).toBe('hello from slow layout')
     |                                                  ^
  33 |         expect($('#slow-page-message').text()).toBe('hello from slow page')
  34 |       })
  35 |     })

  at Object.<anonymous> (e2e/app-dir/app-rendering/rendering.test.ts:32:50)

● app dir rendering › static only › should run data in layout and page

expect(received).toBe(expected) // Object.is equality

Expected: "hello from layout"
Received: ""

  38 |       it('should run data in layout and page', async () => {
  39 |         const $ = await next.render$('/static-only/nested')
> 40 |         expect($('#layout-message').text()).toBe('hello from layout')
     |                                             ^
  41 |         expect($('#page-message').text()).toBe('hello from page')
  42 |       })
  43 |

  at Object.<anonymous> (e2e/app-dir/app-rendering/rendering.test.ts:40:45)

● app dir rendering › static only › should run data in parallel during development

expect(received).toBe(expected) // Object.is equality

Expected: "hello from slow layout"
Received: ""

  54 |         // expect(duration < (isDev ? 7000 : 2000)).toBe(true)
  55 |         // expect(duration < 7000).toBe(true)
> 56 |         expect($('#slow-layout-message').text()).toBe('hello from slow layout')
     |                                                  ^
  57 |         expect($('#slow-page-message').text()).toBe('hello from slow page')
  58 |       })
  59 |     })

  at Object.<anonymous> (e2e/app-dir/app-rendering/rendering.test.ts:56:50)

● app dir rendering › ISR › should revalidate the page when revalidate is configured

expect(received).toBe(expected) // Object.is equality

Expected: "hello from layout"
Received: ""

  71 |         }
  72 |         const { $ } = await getPage()
> 73 |         expect($('#layout-message').text()).toBe('hello from layout')
     |                                             ^
  74 |         expect($('#page-message').text()).toBe('hello from page')
  75 |
  76 |         const layoutNow = $('#layout-now').text()

  at Object.<anonymous> (e2e/app-dir/app-rendering/rendering.test.ts:73:45)

test/integration/404-page-custom-error/test/index.test.js

  • Default 404 Page with custom _error > dev mode > should respond to 404 correctly
  • Default 404 Page with custom _error > dev mode > should render error correctly
  • Default 404 Page with custom _error > dev mode > should render index page normal
Expand output

● Default 404 Page with custom _error › dev mode › should respond to 404 correctly

expect(received).toBe(expected) // Object.is equality

Expected: 404
Received: 500

  24 |   it('should respond to 404 correctly', async () => {
  25 |     const res = await fetchViaHTTP(appPort, '/404')
> 26 |     expect(res.status).toBe(404)
     |                        ^
  27 |     expect(await res.text()).toContain('This page could not be found')
  28 |   })
  29 |

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:26:24)

● Default 404 Page with custom _error › dev mode › should render error correctly

expect(received).toContain(expected) // indexOf

Expected substring: "oops"
Received string:    "Execution of get_from_source failed·
Caused by:
    0: Execution of resolve_source_request failed
    1: Execution of CombinedContentSource::get failed
    2: Execution of create_app_source failed
    3: Execution of load_next_config failed
    4: Execution of evaluate failed
    5: Execution of get_evaluate_pool failed
    6: Execution of turbo_tasks::completion::CompletionsVc::all failed
    7: Execution of turbopack_core::asset::AssetContentVc::write failed
    8: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::content failed
    9: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::code failed
   10: Execution of content_from_relative_path failed
   11: failed to canonicalize embedded file path
   12: No such file or directory (os error 2)"

  30 |   it('should render error correctly', async () => {
  31 |     const text = await renderViaHTTP(appPort, '/err')
> 32 |     expect(text).toContain(isDev ? 'oops' : 'Internal Server Error')
     |                  ^
  33 |   })
  34 |
  35 |   it('should render index page normal', async () => {

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:32:18)

● Default 404 Page with custom _error › dev mode › should render index page normal

expect(received).toContain(expected) // indexOf

Expected substring: "hello from index"
Received string:    "Execution of get_from_source failed·
Caused by:
    0: Execution of resolve_source_request failed
    1: Execution of CombinedContentSource::get failed
    2: Execution of create_app_source failed
    3: Execution of load_next_config failed
    4: Execution of evaluate failed
    5: Execution of get_evaluate_pool failed
    6: Execution of turbo_tasks::completion::CompletionsVc::all failed
    7: Execution of turbopack_core::asset::AssetContentVc::write failed
    8: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::content failed
    9: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::code failed
   10: Execution of content_from_relative_path failed
   11: failed to canonicalize embedded file path
   12: No such file or directory (os error 2)"

  35 |   it('should render index page normal', async () => {
  36 |     const html = await renderViaHTTP(appPort, '/')
> 37 |     expect(html).toContain('hello from index')
     |                  ^
  38 |   })
  39 |
  40 |   if (!isDev) {

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:37:18)

test/development/acceptance-app/component-stack.test.ts

  • Component Stack in error overlay > should show a component stack on hydration error
Expand output

● Component Stack in error overlay › should show a component stack on hydration error

page.waitForSelector: Timeout 30000ms exceeded.
=========================== logs ===========================
waiting for locator('[data-nextjs-toast]')
============================================================

  329 |     return this.chain(() => {
  330 |       return page
> 331 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  332 |         .then(async (el) => {
  333 |           // it seems selenium waits longer and tests rely on this behavior
  334 |           // so we wait for the load event fire before returning

  at lib/browsers/playwright.ts:331:10

test/e2e/edge-compiler-can-import-blob-assets/index.test.ts

  • Edge Compiler can import asset assets > allows to fetch a remote URL
  • Edge Compiler can import asset assets > allows to fetch a remote URL with a path and basename
  • Edge Compiler can import asset assets > allows to fetch text assets
  • Edge Compiler can import asset assets > allows to fetch image assets
  • Edge Compiler can import asset assets > allows to assets from node_modules
  • Edge Compiler can import asset assets > extracts all the assets from the bundle
Expand output

● Edge Compiler can import asset assets › allows to fetch a remote URL

expect(received).toContain(expected) // indexOf

Expected substring: "Example Domain"
Received string:    "Execution of get_from_source failed·
Caused by:
    0: Execution of resolve_source_request failed
    1: Execution of CombinedContentSource::get failed
    2: Execution of create_app_source failed
    3: Execution of load_next_config failed
    4: Execution of evaluate failed
    5: Execution of get_evaluate_pool failed
    6: Execution of turbo_tasks::completion::CompletionsVc::all failed
    7: Execution of turbopack_core::asset::AssetContentVc::write failed
    8: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::content failed
    9: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::code failed
   10: Execution of content_from_relative_path failed
   11: failed to canonicalize embedded file path
   12: No such file or directory (os error 2)"

  27 |       handler: 'remote-full',
  28 |     })
> 29 |     expect(await response.text()).toContain('Example Domain')
     |                                   ^
  30 |   })
  31 |
  32 |   it('allows to fetch a remote URL with a path and basename', async () => {

  at Object.<anonymous> (e2e/edge-compiler-can-import-blob-assets/index.test.ts:29:35)

● Edge Compiler can import asset assets › allows to fetch a remote URL with a path and basename

expect(received).toContain(expected) // indexOf

Expected substring: "Example Domain"
Received string:    "Execution of get_from_source failed·
Caused by:
    0: Execution of resolve_source_request failed
    1: Execution of CombinedContentSource::get failed
    2: Execution of create_app_source failed
    3: Execution of load_next_config failed
    4: Execution of evaluate failed
    5: Execution of get_evaluate_pool failed
    6: Execution of turbo_tasks::completion::CompletionsVc::all failed
    7: Execution of turbopack_core::asset::AssetContentVc::write failed
    8: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::content failed
    9: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::code failed
   10: Execution of content_from_relative_path failed
   11: failed to canonicalize embedded file path
   12: No such file or directory (os error 2)"

  41 |       }
  42 |     )
> 43 |     expect(await response.text()).toContain('Example Domain')
     |                                   ^
  44 |   })
  45 |
  46 |   it('allows to fetch text assets', async () => {

  at Object.<anonymous> (e2e/edge-compiler-can-import-blob-assets/index.test.ts:43:35)

● Edge Compiler can import asset assets › allows to fetch text assets

expect(received).toContain(expected) // indexOf

Expected substring: "Hello, from text-file.txt!"
Received string:    "Execution of get_from_source failed·
Caused by:
    0: Execution of resolve_source_request failed
    1: Execution of CombinedContentSource::get failed
    2: Execution of create_app_source failed
    3: Execution of load_next_config failed
    4: Execution of evaluate failed
    5: Execution of get_evaluate_pool failed
    6: Execution of turbo_tasks::completion::CompletionsVc::all failed
    7: Execution of turbopack_core::asset::AssetContentVc::write failed
    8: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::content failed
    9: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::code failed
   10: Execution of content_from_relative_path failed
   11: failed to canonicalize embedded file path
   12: No such file or directory (os error 2)"

  48 |       handler: 'text-file',
  49 |     })
> 50 |     expect(html).toContain('Hello, from text-file.txt!')
     |                  ^
  51 |   })
  52 |
  53 |   it('allows to fetch image assets', async () => {

  at Object.<anonymous> (e2e/edge-compiler-can-import-blob-assets/index.test.ts:50:18)

● Edge Compiler can import asset assets › allows to fetch image assets

expect(received).toBeTrue()

Expected value to be true:
  true
Received:
  false

  59 |       path.join(__dirname, './app/src/vercel.png')
  60 |     )
> 61 |     expect(buffer.equals(image)).toBeTrue()
     |                                  ^
  62 |   })
  63 |
  64 |   it('allows to assets from node_modules', async () => {

  at Object.<anonymous> (e2e/edge-compiler-can-import-blob-assets/index.test.ts:61:34)

● Edge Compiler can import asset assets › allows to assets from node_modules

FetchError: invalid json response body at http://localhost:37935/api/edge?handler=from-node-module reason: Unexpected token E in JSON at position 0

  66 |       handler: 'from-node-module',
  67 |     })
> 68 |     const json = await response.json()
     |                  ^
  69 |     expect(json).toEqual({
  70 |       'i am': 'a node dependency',
  71 |     })

  at ../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:273:32
  at Object.<anonymous> (e2e/edge-compiler-can-import-blob-assets/index.test.ts:68:18)

● Edge Compiler can import asset assets › extracts all the assets from the bundle

ENOENT: no such file or directory, open '/tmp/next-install-f8375f23b3590ca6ca3bf75fb6669c69b8e491d7b36939530a1ec45a6af24828/.next/server/middleware-manifest.json'

test/integration/404-page-app/test/index.test.js

  • 404 Page Support with _app > dev mode > should not show pages/404 GIP error if _app has GIP
Expand output

● 404 Page Support with _app › dev mode › should not show pages/404 GIP error if _app has GIP

expect(received).toBe(expected) // Object.is equality

Expected: 404
Received: 500

  79 |     it('should not show pages/404 GIP error if _app has GIP', async () => {
  80 |       const res = await fetchViaHTTP(appPort, '/abc')
> 81 |       expect(res.status).toBe(404)
     |                          ^
  82 |       const $ = cheerio.load(await res.text())
  83 |       expect($('#404-title').text()).toBe('Hi There')
  84 |       expect(stderr).not.toMatch(gip404Err)

  at Object.<anonymous> (integration/404-page-app/test/index.test.js:81:26)

test/development/api-cors-with-rewrite/index.test.ts

  • Rewritten API Requests should pass OPTIONS requests to the api function > should pass OPTIONS requests to the api function
Expand output

● Rewritten API Requests should pass OPTIONS requests to the api function › should pass OPTIONS requests to the api function

expect(received).toContain(expected) // indexOf

Expected substring: "successfully hit some-endpoint!"
Received string:    "Execution of get_from_source failed·
Caused by:
    0: Execution of resolve_source_request failed
    1: Execution of CombinedContentSource::get failed
    2: Execution of create_app_source failed
    3: Execution of load_next_config failed
    4: Execution of evaluate failed
    5: Execution of get_evaluate_pool failed
    6: Execution of turbo_tasks::completion::CompletionsVc::all failed
    7: Execution of turbopack_core::asset::AssetContentVc::write failed
    8: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::content failed
    9: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::code failed
   10: Execution of content_from_relative_path failed
   11: failed to canonicalize embedded file path
   12: No such file or directory (os error 2)"

  41 |       },
  42 |     })
> 43 |     expect(await res.text()).toContain('successfully hit some-endpoint!')
     |                              ^
  44 |   })
  45 | })
  46 |

  at Object.<anonymous> (development/api-cors-with-rewrite/index.test.ts:43:30)

test/e2e/app-dir/app-rendering/rendering.test.ts

  • app dir rendering > should serve app/page.server.js at /
  • app dir rendering > ISR > should revalidate the page when revalidate is configured
  • app dir rendering > SSR only > should run data in layout and page
  • app dir rendering > SSR only > should run data fetch in parallel
  • app dir rendering > static only > should run data in layout and page
  • app dir rendering > static only > should run data in parallel during development
Expand output

● app dir rendering › should serve app/page.server.js at /

expect(received).toContain(expected) // indexOf

Expected substring: "app/page.server.js"
Received string:    "Execution of get_from_source failed·
Caused by:
    0: Execution of resolve_source_request failed
    1: Execution of CombinedContentSource::get failed
    2: Execution of create_app_source failed
    3: Execution of load_next_config failed
    4: Execution of evaluate failed
    5: Execution of get_evaluate_pool failed
    6: Execution of turbo_tasks::completion::CompletionsVc::all failed
    7: Execution of turbopack_core::asset::AssetContentVc::write failed
    8: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::content failed
    9: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::code failed
   10: Execution of content_from_relative_path failed
   11: failed to canonicalize embedded file path
   12: No such file or directory (os error 2)"

  12 |     it('should serve app/page.server.js at /', async () => {
  13 |       const html = await next.render('/')
> 14 |       expect(html).toContain('app/page.server.js')
     |                    ^
  15 |     })
  16 |
  17 |     describe('SSR only', () => {

  at Object.<anonymous> (e2e/app-dir/app-rendering/rendering.test.ts:14:20)

● app dir rendering › SSR only › should run data in layout and page

expect(received).toBe(expected) // Object.is equality

Expected: "hello from layout"
Received: ""

  18 |       it('should run data in layout and page', async () => {
  19 |         const $ = await next.render$('/ssr-only/nested')
> 20 |         expect($('#layout-message').text()).toBe('hello from layout')
     |                                             ^
  21 |         expect($('#page-message').text()).toBe('hello from page')
  22 |       })
  23 |

  at Object.<anonymous> (e2e/app-dir/app-rendering/rendering.test.ts:20:45)

● app dir rendering › SSR only › should run data fetch in parallel

expect(received).toBe(expected) // Object.is equality

Expected: "hello from slow layout"
Received: ""

  30 |         // Using 7 seconds to ensure external factors causing slight slowness don't fail the tests
  31 |         expect(duration < 7000).toBe(true)
> 32 |         expect($('#slow-layout-message').text()).toBe('hello from slow layout')
     |                                                  ^
  33 |         expect($('#slow-page-message').text()).toBe('hello from slow page')
  34 |       })
  35 |     })

  at Object.<anonymous> (e2e/app-dir/app-rendering/rendering.test.ts:32:50)

● app dir rendering › static only › should run data in layout and page

expect(received).toBe(expected) // Object.is equality

Expected: "hello from layout"
Received: ""

  38 |       it('should run data in layout and page', async () => {
  39 |         const $ = await next.render$('/static-only/nested')
> 40 |         expect($('#layout-message').text()).toBe('hello from layout')
     |                                             ^
  41 |         expect($('#page-message').text()).toBe('hello from page')
  42 |       })
  43 |

  at Object.<anonymous> (e2e/app-dir/app-rendering/rendering.test.ts:40:45)

● app dir rendering › static only › should run data in parallel during development

expect(received).toBe(expected) // Object.is equality

Expected: "hello from slow layout"
Received: ""

  54 |         // expect(duration < (isDev ? 7000 : 2000)).toBe(true)
  55 |         // expect(duration < 7000).toBe(true)
> 56 |         expect($('#slow-layout-message').text()).toBe('hello from slow layout')
     |                                                  ^
  57 |         expect($('#slow-page-message').text()).toBe('hello from slow page')
  58 |       })
  59 |     })

  at Object.<anonymous> (e2e/app-dir/app-rendering/rendering.test.ts:56:50)

● app dir rendering › ISR › should revalidate the page when revalidate is configured

expect(received).toBe(expected) // Object.is equality

Expected: "hello from layout"
Received: ""

  71 |         }
  72 |         const { $ } = await getPage()
> 73 |         expect($('#layout-message').text()).toBe('hello from layout')
     |                                             ^
  74 |         expect($('#page-message').text()).toBe('hello from page')
  75 |
  76 |         const layoutNow = $('#layout-now').text()

  at Object.<anonymous> (e2e/app-dir/app-rendering/rendering.test.ts:73:45)

test/integration/404-page-custom-error/test/index.test.js

  • Default 404 Page with custom _error > dev mode > should respond to 404 correctly
  • Default 404 Page with custom _error > dev mode > should render error correctly
  • Default 404 Page with custom _error > dev mode > should render index page normal
Expand output

● Default 404 Page with custom _error › dev mode › should respond to 404 correctly

expect(received).toBe(expected) // Object.is equality

Expected: 404
Received: 500

  24 |   it('should respond to 404 correctly', async () => {
  25 |     const res = await fetchViaHTTP(appPort, '/404')
> 26 |     expect(res.status).toBe(404)
     |                        ^
  27 |     expect(await res.text()).toContain('This page could not be found')
  28 |   })
  29 |

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:26:24)

● Default 404 Page with custom _error › dev mode › should render error correctly

expect(received).toContain(expected) // indexOf

Expected substring: "oops"
Received string:    "Execution of get_from_source failed·
Caused by:
    0: Execution of resolve_source_request failed
    1: Execution of CombinedContentSource::get failed
    2: Execution of create_app_source failed
    3: Execution of load_next_config failed
    4: Execution of evaluate failed
    5: Execution of get_evaluate_pool failed
    6: Execution of turbo_tasks::completion::CompletionsVc::all failed
    7: Execution of turbopack_core::asset::AssetContentVc::write failed
    8: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::content failed
    9: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::code failed
   10: Execution of content_from_relative_path failed
   11: failed to canonicalize embedded file path
   12: No such file or directory (os error 2)"

  30 |   it('should render error correctly', async () => {
  31 |     const text = await renderViaHTTP(appPort, '/err')
> 32 |     expect(text).toContain(isDev ? 'oops' : 'Internal Server Error')
     |                  ^
  33 |   })
  34 |
  35 |   it('should render index page normal', async () => {

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:32:18)

● Default 404 Page with custom _error › dev mode › should render index page normal

expect(received).toContain(expected) // indexOf

Expected substring: "hello from index"
Received string:    "Execution of get_from_source failed·
Caused by:
    0: Execution of resolve_source_request failed
    1: Execution of CombinedContentSource::get failed
    2: Execution of create_app_source failed
    3: Execution of load_next_config failed
    4: Execution of evaluate failed
    5: Execution of get_evaluate_pool failed
    6: Execution of turbo_tasks::completion::CompletionsVc::all failed
    7: Execution of turbopack_core::asset::AssetContentVc::write failed
    8: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::content failed
    9: Execution of turbopack_ecmascript::chunk::EcmascriptChunkContentVc::code failed
   10: Execution of content_from_relative_path failed
   11: failed to canonicalize embedded file path
   12: No such file or directory (os error 2)"

  35 |   it('should render index page normal', async () => {
  36 |     const html = await renderViaHTTP(appPort, '/')
> 37 |     expect(html).toContain('hello from index')
     |                  ^
  38 |   })
  39 |
  40 |   if (!isDev) {

  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:37:18)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Benchmark for 689f899

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack RSC/1000 modules 508.68ms ± 1.78ms 520.74ms ± 2.52ms +2.37% +0.68%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 10.21ms ± 0.09ms 10.24ms ± 0.09ms +0.26%
bench_hmr_to_commit/Turbopack RCC/1000 modules 10.40ms ± 0.10ms 10.51ms ± 0.08ms +0.99%
bench_hmr_to_commit/Turbopack RSC/1000 modules 508.68ms ± 1.78ms 520.74ms ± 2.52ms +2.37% +0.68%
bench_hmr_to_commit/Turbopack SSR/1000 modules 10.39ms ± 0.09ms 10.32ms ± 0.07ms -0.66%
bench_hmr_to_eval/Turbopack CSR/1000 modules 9140.61µs ± 59.06µs 9117.99µs ± 89.72µs -0.25%
bench_hmr_to_eval/Turbopack RCC/1000 modules 9388.85µs ± 79.69µs 9364.23µs ± 86.88µs -0.26%
bench_hmr_to_eval/Turbopack SSR/1000 modules 9256.08µs ± 94.60µs 9289.39µs ± 67.26µs +0.36%
bench_hydration/Turbopack RCC/1000 modules 4389.55ms ± 7.62ms 4397.02ms ± 12.41ms +0.17%
bench_hydration/Turbopack RSC/1000 modules 3987.47ms ± 13.84ms 3978.03ms ± 21.83ms -0.24%
bench_hydration/Turbopack SSR/1000 modules 3792.35ms ± 19.46ms 3788.11ms ± 12.26ms -0.11%
bench_startup/Turbopack CSR/1000 modules 2891.59ms ± 10.31ms 2892.19ms ± 7.15ms +0.02%
bench_startup/Turbopack RCC/1000 modules 2678.79ms ± 7.64ms 2674.35ms ± 6.75ms -0.17%
bench_startup/Turbopack RSC/1000 modules 2563.66ms ± 7.92ms 2553.20ms ± 6.07ms -0.41%
bench_startup/Turbopack SSR/1000 modules 2130.42ms ± 2.65ms 2123.44ms ± 1.91ms -0.33%

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests

See workflow summary for details

@kwonoj kwonoj added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 5, 2023
@kwonoj kwonoj merged commit 6cbb835 into main Feb 7, 2023
@kwonoj kwonoj deleted the summary-error-fix branch February 7, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants