Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove quotes around extension in makefile #3662

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

chris-olszewski
Copy link
Contributor

There was an issue with building the go binary on windows.

Before this PR:

make -p
...
go-turbo".exe": internal/turbodprotocol/turbod.pb.go internal/turbodprotocol/turbod_grpc.pb.go go.mod turborepo-ffi-install
...

Now dropping the quotes we get the desired build target:

make -p
...
go-turbo.exe: internal/turbodprotocol/turbod.pb.go internal/turbodprotocol/turbod_grpc.pb.go go.mod turborepo-ffi-install
...

and make go-turbo.exe works.

@vercel
Copy link

vercel bot commented Feb 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-cra-web 🔄 Building (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-native-web 🔄 Building (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-nonmonorepo 🔄 Building (Inspect) Feb 6, 2023 at 11:02PM (UTC)
7 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2023 at 11:02PM (UTC)

@chris-olszewski chris-olszewski marked this pull request as ready for review February 6, 2023 22:17
@chris-olszewski chris-olszewski requested a review from a team as a code owner February 6, 2023 22:17
Copy link
Contributor

@NicholasLYang NicholasLYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Go e2e tests

See workflow summary for details

@chris-olszewski chris-olszewski enabled auto-merge (squash) February 6, 2023 23:13
@chris-olszewski chris-olszewski merged commit 79c7158 into main Feb 7, 2023
@chris-olszewski chris-olszewski deleted the olszewski/fixes_makefile_for_windows branch February 7, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants