Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: turbo login on Windows #3664

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Conversation

chris-olszewski
Copy link
Contributor

@chris-olszewski chris-olszewski commented Feb 6, 2023

Fixes #3647

Issue was that we were constructing a header with an unescaped \r on Windows as the user agent.

CRLF is the gift that keeps on giving

@chris-olszewski chris-olszewski marked this pull request as ready for review February 6, 2023 23:02
@chris-olszewski chris-olszewski requested a review from a team as a code owner February 6, 2023 23:02
@vercel
Copy link

vercel bot commented Feb 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Feb 6, 2023 at 11:02PM (UTC)
9 Ignored Deployments
Name Status Preview Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 6, 2023 at 11:02PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

🟢 CI successful 🟢

Thanks

@chris-olszewski chris-olszewski merged commit 97a8870 into main Feb 7, 2023
@chris-olszewski chris-olszewski deleted the olszewski/fix_windows_login branch February 7, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[turborepo] Login Fails on Windows 11 Home
2 participants