fix integration tests on windows #3737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… start avoid Drop implementation in favor of kill_on_drop
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
|
Benchmark for 0efa344
Click to view full benchmark
|
Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
sokra
force-pushed
the
sokra/web-568-and-web-387-windows-test-timeout
branch
from
0755221
to
4665973
Compare
Benchmark for 4a5d4c0
Click to view full benchmark
|
Benchmark for d772ddcClick to view benchmark
|
Benchmark for b25364a
Click to view full benchmark
|
Benchmark for 2022745Click to view benchmark
|
Brooooooklyn
approved these changes
Feb 13, 2023
sokra
added
the
pr: automerge
kodiakhq
bot
deleted the
sokra/web-568-and-web-387-windows-test-timeout
branch
ijjk
added a commit
to vercel/next.js
that referenced
this pull request
Feb 13, 2023
# New Features - vercel/turbo#3695 - vercel/turbo#3696 # Performance - vercel/turbo#3738 - vercel/turbo#3714 - vercel/turbo#3739 # Fixes - vercel/turbo#3718 - vercel/turbo#3618 - vercel/turbo#3736 # Other Changes - vercel/turbo#3731 - vercel/turbo#3733 - vercel/turbo#3629 - vercel/turbo#3769 - vercel/turbo#3707 - vercel/turbo#3737 - vercel/turbo#3770 Co-authored-by: JJ Kasper <jj@jjsweb.site>
| @@ -39,6 +39,14 @@ struct SpawnedNodeJsPoolProcess { | |||
| struct RunningNodeJsPoolProcess { | |||
| child: Option<Child>, | |||
| connection: TcpStream, | |||
| stdout_buf: Vec<u8>, | |||
There was a problem hiding this comment.
this just keeps getting worse
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
For windows it's important that the browser is dropped so that the test can complete. To do that we need to cancel the spawned task below (which will drop the browser). For this we are using a JoinSet which cancels all tasks when dropped.
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
For windows it's important that the browser is dropped so that the test can complete. To do that we need to cancel the spawned task below (which will drop the browser). For this we are using a JoinSet which cancels all tasks when dropped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For windows it's important that the browser is dropped so that the test can
complete. To do that we need to cancel the spawned task below (which will
drop the browser). For this we are using a JoinSet which cancels all tasks
when dropped.