Use IndexSet in IntrospectableChildrenVc #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Alex Kirszenberg <1621758+alexkirsz@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 10 Ignored Deployments
|
|
Benchmark for 6ada6e3Click to view benchmark
|
sokra
approved these changes
Feb 17, 2023
sokra
reviewed
Feb 17, 2023
jridgewell
commented
Feb 17, 2023
| @@ -120,7 +120,6 @@ impl ContentSource for IntrospectionSource { | |||
| }) | |||
| .try_join() | |||
| .await?; | |||
| children.sort(); | |||
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
Another small cleanup stemming from the the `basePath` PR. Makes the introspection ordering consistent, which is a nice usability win. Co-authored-by: Alex Kirszenberg <1621758+alexkirsz@users.noreply.github.com>
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Another small cleanup stemming from the the `basePath` PR. Makes the introspection ordering consistent, which is a nice usability win. Co-authored-by: Alex Kirszenberg <1621758+alexkirsz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small cleanup stemming from the the
basePathPR. Makes the introspection ordering consistent, which is a nice usability win.