Implement Rewrite Headers support during routing #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
wbinnssmith
approved these changes
Feb 21, 2023
|
I'm working on the test cases for Rewrite/Redirect/Headers now. |
|
Tests implemented for Rewrite/Redirect, but the Headers support just landed in Next side and I can't test it until we update our canary dep. |
|
I've manually confirmed this works once by duplicating vercel/next.js@185a892. |
jridgewell
added
the
pr: automerge
padmaia
approved these changes
Feb 21, 2023
Benchmark for e0f37ec
Click to view full benchmark
|
|
Merging over some test flake. |
kodiak could handle this now. It won't block on mac or windows CI anymore. |
ijjk
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 22, 2023
# Features * vercel/turbo#3897 * vercel/turbo#3670 # Bug Fixes * vercel/turbo#3894 * vercel/turbo#3910 * vercel/turbo#3895 * vercel/turbo#3912 * vercel/turbo#3805 # Performance Improvements * vercel/turbo#3836
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final piece to supporting Rewrites is implementing support for overwriting response headers. These overwritten headers need to be collected until we resolve into a final
ContentSourceContent::Static(which gets turned intoResolveSourceRequestResult, thenGetFromSourceResult) to be returned into the HTTP response.I chose to implement this as an external list from the headers already present in a
ContentSourceContent::Static. It felt wrong tocontent.await?just to overwrite the returned headers, and then repackage that as a newContentSourceContentVc. Theseheader_overwritesexist only as a byproduct of route resolution, and specifically the exact path of rewrites we go through to get there. They're not intrinsic to theContentSourceContentitself.Fixes WEB-617
Fixes WEB-299