next/font: Align with Next.js integration test suite #4039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This: * Adds a compile-time feature, `__internal_nextjs_integration_test`, which is set when building Turbopack for the Next.js integration test suite. * When built with `__internal_nextjs_integration_test`, expects the environment variable `NEXT_FONT_GOOGLE_MOCKED_RESPONSES` to be set with an absolute path to a JavaScript file exporting a mapping of urls to stylesheet text. This is used in place of making real requests to Google Fonts. * Addresses some small bugs in next/font/google to bring the implementation in line with the urls generated by Next.js without Turbopack. * Changes classnames generated by next/font to use 6 character hashes, bringing it in alignment with Next.js without Turbopack. Test Plan: * Adjusted existing unit tests * In Next.js, `node run-tests.js -c 1 test/e2e/next-font/index.test.ts`
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
kwonoj
reviewed
Mar 1, 2023
🟢 CI successful 🟢Thanks |
Benchmark for 73037e6Click to view benchmark
|
hanneslund
approved these changes
Mar 2, 2023
Benchmark for fa550d8
Click to view full benchmark
|
Benchmark for dbca786
Click to view full benchmark
|
Benchmark for dbca786Click to view benchmark
|
kwonoj
approved these changes
Mar 4, 2023
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
This: * Adds a compile-time feature, `__internal_nextjs_integration_test`, which is set when building Turbopack for the Next.js integration test suite. * When built with `__internal_nextjs_integration_test`, expects the environment variable `NEXT_FONT_GOOGLE_MOCKED_RESPONSES` to be set with an absolute path to a JavaScript file exporting a mapping of urls to stylesheet text. This is used in place of making real requests to Google Fonts. * Addresses some small bugs in next/font/google to bring the implementation in line with the urls generated by Next.js without Turbopack. * Changes classnames generated by next/font to use 6 character hashes, bringing it in alignment with Next.js without Turbopack. Test Plan: * Adjusted existing unit tests * In Next.js, `node run-tests.js -c 1 test/e2e/next-font/index.test.ts` ### Description <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> <!-- When the below is checked (default) our PR bot will automatically assign labels to your PR based on the content to help the team organize and review it faster. --> - [x] Auto label
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
This: * Adds a compile-time feature, `__internal_nextjs_integration_test`, which is set when building Turbopack for the Next.js integration test suite. * When built with `__internal_nextjs_integration_test`, expects the environment variable `NEXT_FONT_GOOGLE_MOCKED_RESPONSES` to be set with an absolute path to a JavaScript file exporting a mapping of urls to stylesheet text. This is used in place of making real requests to Google Fonts. * Addresses some small bugs in next/font/google to bring the implementation in line with the urls generated by Next.js without Turbopack. * Changes classnames generated by next/font to use 6 character hashes, bringing it in alignment with Next.js without Turbopack. Test Plan: * Adjusted existing unit tests * In Next.js, `node run-tests.js -c 1 test/e2e/next-font/index.test.ts` ### Description <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> <!-- When the below is checked (default) our PR bot will automatically assign labels to your PR based on the content to help the team organize and review it faster. --> - [x] Auto label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
__internal_nextjs_integration_test, which is set when building Turbopack for the Next.js integration test suite.__internal_nextjs_integration_test, expects the environment variableNEXT_FONT_GOOGLE_MOCKED_RESPONSESto be set with an absolute path to a JavaScript file exporting a mapping of urls to stylesheet text. This is used in place of making real requests to Google Fonts.Test Plan:
node run-tests.js -c 1 test/e2e/next-font/index.test.tsDescription
Testing Instructions