Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(workflow): fix build errors #4082

Merged
merged 1 commit into from Mar 6, 2023
Merged

ci(workflow): fix build errors #4082

merged 1 commit into from Mar 6, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Mar 6, 2023

Description

Minor fix for the daily next.js test runs.

@kwonoj kwonoj requested review from a team as code owners March 6, 2023 16:18
@kwonoj kwonoj requested review from mehulkar and arlyon March 6, 2023 16:18
@vercel
Copy link

vercel bot commented Mar 6, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

10 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Mar 6, 2023 at 6:04PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Mar 6, 2023 at 6:04PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 6, 2023 at 6:04PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 6, 2023 at 6:04PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Mar 6, 2023 at 6:04PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Mar 6, 2023 at 6:04PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Mar 6, 2023 at 6:04PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 6, 2023 at 6:04PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Mar 6, 2023 at 6:04PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2023 at 6:04PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Determining jobs

See workflow summary for details

@mehulkar mehulkar removed their request for review March 6, 2023 17:00
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Benchmark for 5db1dd6

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9281.28µs ± 66.02µs 9184.87µs ± 34.52µs -1.04%
bench_hmr_to_commit/Turbopack RCC/1000 modules 13.57ms ± 0.20ms 13.90ms ± 0.08ms +2.42%
bench_hmr_to_commit/Turbopack RSC/1000 modules 499.30ms ± 1.01ms 499.88ms ± 1.18ms +0.12%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9554.22µs ± 34.32µs 9487.20µs ± 54.13µs -0.70%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8213.08µs ± 45.20µs 8183.40µs ± 41.63µs -0.36%
bench_hmr_to_eval/Turbopack RCC/1000 modules 12.52ms ± 0.22ms 12.26ms ± 0.35ms -2.08%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8441.26µs ± 70.98µs 8425.91µs ± 32.42µs -0.18%
bench_hydration/Turbopack RCC/1000 modules 3597.64ms ± 10.53ms 3600.12ms ± 9.88ms +0.07%
bench_hydration/Turbopack RSC/1000 modules 3251.79ms ± 14.29ms 3238.51ms ± 12.17ms -0.41%
bench_hydration/Turbopack SSR/1000 modules 3321.00ms ± 5.21ms 3302.75ms ± 6.26ms -0.55%
bench_startup/Turbopack CSR/1000 modules 2572.10ms ± 4.45ms 2561.50ms ± 3.19ms -0.41%
bench_startup/Turbopack RCC/1000 modules 2130.12ms ± 5.00ms 2132.41ms ± 2.19ms +0.11%
bench_startup/Turbopack RSC/1000 modules 2058.74ms ± 5.22ms 2055.28ms ± 3.25ms -0.17%
bench_startup/Turbopack SSR/1000 modules 2043.05ms ± 2.91ms 2039.44ms ± 3.57ms -0.18%

@kwonoj kwonoj merged commit 6d9855e into main Mar 6, 2023
@kwonoj kwonoj deleted the fix-build-test branch March 6, 2023 18:03
kwonoj added a commit that referenced this pull request Mar 6, 2023
@kwonoj
ci(workflow): fix build errors (#4082)
e4669dd 
### Description

Minor fix for the daily next.js test runs.
kwonoj added a commit that referenced this pull request Mar 6, 2023
@kwonoj
ci(workflow): fix build errors (#4082)
459cb95 
### Description

Minor fix for the daily next.js test runs.
kwonoj added a commit that referenced this pull request Mar 6, 2023
@kwonoj
ci(workflow): fix build errors (#4082)
0fb27a2 
### Description

Minor fix for the daily next.js test runs.
kwonoj added a commit that referenced this pull request Mar 6, 2023
@kwonoj
ci(workflow): fix build errors (#4082)
69f7ecc 
### Description

Minor fix for the daily next.js test runs.
kdy1 added a commit to kdy1/next.js that referenced this pull request Mar 7, 2023
@kdy1
Apply fix from vercel/turbo#4082
06122cf
kdy1 added a commit to kdy1/next.js that referenced this pull request Mar 7, 2023
@kdy1
Revert "Apply fix from vercel/turbo#4082"
d9f05a1 
This reverts commit 06122cf.
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@kwonoj
ci(workflow): fix build errors (vercel/turbo#4082)
ce732f5 
### Description

Minor fix for the daily next.js test runs.
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@kwonoj
ci(workflow): fix build errors (vercel/turbo#4082)
2d4d758 
### Description

Minor fix for the daily next.js test runs.
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

@arlyon arlyon Awaiting requested review from arlyon arlyon is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwonoj @wbinnssmith