fix error handling and hanging problems #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
🟢 CI likely successful 🟢A few longer running steps are still running, but they should not be considered as blocking. See workflow summary for details |
sokra
force-pushed
the
sokra/node-fatal-error
branch
from
735422d
to
f93b6d5
Compare
sokra
force-pushed
the
sokra/node-fatal-error
branch
from
77df302
to
6b935dd
Compare
sokra
changed the title
alexkirsz
suggested changes
Mar 24, 2023
Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
alexkirsz
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to ensure that Vc reads and connected Tasks are correctly handled in when producing streams. It's important that the Tasks are connected to something that is active when consumers read from the stream. Also Vc reads need to invalidate the stream and cause the production of a new stream. That was not handled correctly before.
Now we use a child task to produce the stream that is active as part of the function that returns the stream. We also use a little hack to update the stream in the parent task when the child task is invalidated.
It's a bit hacky, but eventually this kind of logic should probably move into turbo_tasks as part of some streaming concept.
Testing Instructions
Placing
process.exit(0)innext.config.jsorpostcss.config.js