Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn lockfile parsing on Windows #434

Merged
merged 3 commits into from
Dec 24, 2021
Merged

Fix yarn lockfile parsing on Windows #434

merged 3 commits into from
Dec 24, 2021

Conversation

jaredpalmer
Copy link
Contributor

@jaredpalmer jaredpalmer commented Dec 24, 2021

Fix #252 #145 #394

Finally got a Windows machine for work. This PR fixes a handful of Windows bugs:

  • Fixes yarn based build command w/ cross-env package
  • Fixes "parsing" (i.e. regexing yarn.lock SYML into YAML with correct line endings)
  • Removes hacky CheckIfWindows
  • Windows users should now have same hashes as non-windows users

@vercel
Copy link

vercel bot commented Dec 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/HiXYDVunGVj1eCHyY4wxXG5RRFhj
✅ Preview: https://turbo-site-git-add-cross-env.vercel.sh

@jaredpalmer jaredpalmer added the area: windows Issues specifically reproducing on Windows label Dec 24, 2021
@jaredpalmer jaredpalmer changed the title Fix lockfile parsing on Windows Fix yarn lockfile parsing on Windows Dec 24, 2021
@bel7aG
Copy link

bel7aG commented May 29, 2022

The error still in turbo@1.2.14 in Ubuntu on Windows..

ERROR yarn.lock: failed to hash lockfile: open /mnt/c/Users/whoami/Desktop/blabla/projects/blabla/yarn.lock: no such file or directory

sokra added a commit that referenced this pull request Oct 25, 2022
(Prerequirement for `app` support)

Move ValueToString to EcmascriptChunk
remove id from chunk item content
add id/path to chunk item
remove context arguments from content and code generation Derive specific context from general context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: windows Issues specifically reproducing on Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turborepo cant unmarshall yarn lock generated under (crlf) windows on linux (lf)
2 participants