Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(turbopack): remove next.js specific unsupported warn #4697

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Apr 25, 2023

Description

WEB-953.

This PR removes check for next.js specific unsupported packages. Instead, let next-* (next-core) handles it via resolve plugin. See vercel/next.js#48837 for the corresponding change. This change makes turbopack does not need to aware specific next.js package names.

@kwonoj kwonoj requested a review from a team as a code owner April 25, 2023 19:05
@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Apr 26, 2023 0:47am
examples-tailwind-web 🔄 Building (Inspect) Apr 26, 2023 0:47am
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 26, 2023 0:47am
examples-cra-web ⬜️ Ignored (Inspect) Apr 26, 2023 0:47am
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 26, 2023 0:47am
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 26, 2023 0:47am
examples-native-web ⬜️ Ignored (Inspect) Apr 26, 2023 0:47am
examples-nonmonorepo ⬜️ Ignored (Inspect) Apr 26, 2023 0:47am
examples-svelte-web ⬜️ Ignored (Inspect) Apr 26, 2023 0:47am
examples-vite-web ⬜️ Ignored (Inspect) Apr 26, 2023 0:47am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2023 0:47am

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2023

🟢 CI successful 🟢

Thanks

@kwonoj kwonoj added the pr: automerge Kodiak will merge these automatically after checks pass label Apr 26, 2023
@kodiakhq kodiakhq bot merged commit 946307c into main Apr 26, 2023
41 checks passed
@kodiakhq kodiakhq bot deleted the remove-unsupported-warn branch April 26, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants