Rename Turbopack/tasks crates to common prefixes #4866
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
|
✅ This change can build |
Cargo.toml
Outdated
| @@ -50,14 +18,12 @@ members = [ | |||
| "crates/turborepo-lockfiles", | |||
| "crates/turborepo-scm", | |||
| "crates/turborepo-vercel-api-mock", | |||
| "crates/utils/*", | |||
There was a problem hiding this comment.
Can we have this be turbopack-utils?
There was a problem hiding this comment.
It doesn't make much sense, as auto-hash-map is only used by turbo-tasks, while swc-ast-explorer is its own thing independent of both.
auto-hash-map could go into a turbo-tasks-utils. swc-ast-explorer could be renamed turbopack-utils/swc-ast-explorer.
There was a problem hiding this comment.
Yeah that would be preferable. I think we should avoid having any ambiguous folders, otherwise it'd be too easy for us to accidentally put a turborepo crate in utils/
There was a problem hiding this comment.
Unfortunately, this breaks the glob pattern for turbopack* and turbo-tasks* above, as turbo-tasks-utils wouldn't be a crate, but turbo-tasks-utils/auto-hash-map would. The solution here is to keep everything flat and rename them turbo-tasks-auto-hash-map and turbopack-swc-ast-explorer.
There was a problem hiding this comment.
Yeah now that I remember, I ran into this exact issue lol. Ah the frustrations of globbing...
There was a problem hiding this comment.
Technically auto-hash-map is not related to turbo-tasks, but nevermind
alexkirsz
force-pushed
the
alexkirsz/web-1015-rename-crates
branch
from
e7083d1
to
7e2fa3d
Compare
alexkirsz
added
the
pr: automerge
See vercel/turbo#4866 This also updates Turbopack to turbopack-230511.2 with the following changes: * vercel/turbo#4636 <!-- Alex Kirszenberg - Add support for logging events and intervals in the macOS profiler --> * vercel/turbo#4793 <!-- OJ Kwon - ci(workflow): enable more test --> * vercel/turbo#4886 <!-- OJ Kwon - refactor(ecmascript-plugins): update serverdirective signature --> * vercel/turbo#4866 <!-- Alex Kirszenberg - Rename Turbopack/tasks crates to common prefixes -->
Description
See #4853 for the corresponding change on the turborepo side.
Testing Instructions
link WEB-1015