refactor(ecmsacript): remove custom transform cloned return #4881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
kwonoj
force-pushed
the
refactor-custom-transformer
branch
from
18559c2
to
cc8cac4
Compare
kwonoj
changed the title
sokra
approved these changes
May 10, 2023
kwonoj
added
the
pr: automerge
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
May 10, 2023
### What? - closes WEB-1024. Minor refactoring to avoid explicit AST cloning. Still visitors are using fold though. ### Turbopack changes * vercel/turbo#4869 * vercel/turbo#4879 * vercel/turbo#4881
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part 1 for WEB-1024.
PR refactors custom transformer signature to not allow to return cloned instance. Also moves out few non-core transforms into plugins, so next.js turbopack can use it.
Next.js changes: vercel/next.js#49560