Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ecmsacript): remove custom transform cloned return #4881

Merged
merged 5 commits into from
May 10, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented May 9, 2023

Description

Part 1 for WEB-1024.

PR refactors custom transformer signature to not allow to return cloned instance. Also moves out few non-core transforms into plugins, so next.js turbopack can use it.

Next.js changes: vercel/next.js#49560

@kwonoj kwonoj requested a review from a team as a code owner May 9, 2023 18:11
@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-vite-web 🔄 Building (Inspect) May 10, 2023 0:26am
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 10, 2023 0:26am
examples-cra-web ⬜️ Ignored (Inspect) May 10, 2023 0:26am
examples-designsystem-docs ⬜️ Ignored (Inspect) May 10, 2023 0:26am
examples-gatsby-web ⬜️ Ignored (Inspect) May 10, 2023 0:26am
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 10, 2023 0:26am
examples-native-web ⬜️ Ignored (Inspect) May 10, 2023 0:26am
examples-nonmonorepo ⬜️ Ignored (Inspect) May 10, 2023 0:26am
examples-svelte-web ⬜️ Ignored (Inspect) May 10, 2023 0:26am
examples-tailwind-web ⬜️ Ignored (Inspect) May 10, 2023 0:26am
turbo-site ⬜️ Ignored (Inspect) Visit Preview May 10, 2023 0:26am

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

🟢 CI successful 🟢

Thanks

@kwonoj kwonoj force-pushed the refactor-custom-transformer branch from 18559c2 to cc8cac4 Compare May 10, 2023 00:26
@kwonoj kwonoj changed the title refactor(ecmsacript): remove custom trnasform cloned return refactor(ecmsacript): remove custom transform cloned return May 10, 2023
@kwonoj kwonoj added the pr: automerge Kodiak will merge these automatically after checks pass label May 10, 2023
@kodiakhq kodiakhq bot merged commit 95be42a into main May 10, 2023
@kodiakhq kodiakhq bot deleted the refactor-custom-transformer branch May 10, 2023 07:34
sokra pushed a commit to vercel/next.js that referenced this pull request May 10, 2023
### What?

- closes WEB-1024.

Minor refactoring to avoid explicit AST cloning. Still visitors are
using fold though.

### Turbopack changes

* vercel/turborepo#4869
* vercel/turborepo#4879
* vercel/turborepo#4881
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…urborepo#4881)

### Description

Part 1 for WEB-1024.

PR refactors custom transformer signature to not allow to return cloned
instance. Also moves out few non-core transforms into plugins, so
next.js turbopack can use it.

Next.js changes: #49560
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…urborepo#4881)

### Description

Part 1 for WEB-1024.

PR refactors custom transformer signature to not allow to return cloned
instance. Also moves out few non-core transforms into plugins, so
next.js turbopack can use it.

Next.js changes: #49560
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…urborepo#4881)

### Description

Part 1 for WEB-1024.

PR refactors custom transformer signature to not allow to return cloned
instance. Also moves out few non-core transforms into plugins, so
next.js turbopack can use it.

Next.js changes: #49560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants