Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(turbo-gen): support TS config files #4950

Merged
merged 1 commit into from
May 15, 2023

Conversation

tknickman
Copy link
Member

Description

  • Add support for TS generator config files
  • Converts all of our generator configs to TS

@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 5:37pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 15, 2023 5:37pm
examples-cra-web ⬜️ Ignored (Inspect) May 15, 2023 5:37pm
examples-designsystem-docs ⬜️ Ignored (Inspect) May 15, 2023 5:37pm
examples-gatsby-web ⬜️ Ignored (Inspect) May 15, 2023 5:37pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 15, 2023 5:37pm
examples-native-web ⬜️ Ignored (Inspect) May 15, 2023 5:37pm
examples-nonmonorepo ⬜️ Ignored (Inspect) May 15, 2023 5:37pm
examples-svelte-web ⬜️ Ignored (Inspect) May 15, 2023 5:37pm
examples-tailwind-web ⬜️ Ignored (Inspect) May 15, 2023 5:37pm
examples-vite-web ⬜️ Ignored (Inspect) May 15, 2023 5:37pm

@github-actions
Copy link
Contributor

✅ This change can build next-swc

Comment on lines +15 to +19
fetch("https://api.github.com/repos/vercel/turbo"),
fetch("https://api.npmjs.org/versions/turbo/last-week"),
fetch(
`https://api.us-east.tinybird.co/v0/pipes/turborepo_time_saved_ticker.json?token=${PUBLIC_TB_TOKEN}`
),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for you @mehulkar 😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YESSSSSSSSS. Next up we drop jest for node:test

Comment on lines +30 to +32
register({
transpileOnly: true,
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plop does support TS configs, but it relies on ts-node being configured plopjs/plop#192 (comment)

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@tknickman tknickman merged commit 0f6cd6a into main May 15, 2023
35 of 36 checks passed
@tknickman tknickman deleted the tomknickman/turbo-1103-support-ts-config-files branch May 15, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants