Add ServerInfo struct for node rendering #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
✅ This change can build |
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
May 18, 2023
|
Linux Benchmark for f410295
Click to view full benchmark
|
kwonoj
approved these changes
May 18, 2023
MacOS Benchmark for f410295
Click to view full benchmark
|
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
May 18, 2023
ijjk
pushed a commit
to vercel/next.js
that referenced
this pull request
May 19, 2023
This PR forwards the [new `ServerInfo`](vercel/turbo#5018) struct to Turbopack's rendering processes, allowing it to initialize the requesting headers with the `x-forwarded-*` headers. These headers, and `x-forwarded-proto` in particular, are necessary for [NextAuth to work](https://github.com/nextauthjs/next-auth/blob/f62c0167/packages/next-auth/src/core/index.ts#L73-L76). These headers are initialized in the non-turbo server via [`http-proxy`](https://github.com/http-party/node-http-proxy/blob/9b96cd72/lib/http-proxy/passes/web-incoming.js#L58-L86). Fixes WEB-1064
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
This PR forwards the [new `ServerInfo`](vercel/turbo#5018) struct to Turbopack's rendering processes, allowing it to initialize the requesting headers with the `x-forwarded-*` headers. These headers, and `x-forwarded-proto` in particular, are necessary for [NextAuth to work](https://github.com/nextauthjs/next-auth/blob/f62c0167/packages/next-auth/src/core/index.ts#L73-L76). These headers are initialized in the non-turbo server via [`http-proxy`](https://github.com/http-party/node-http-proxy/blob/9b96cd72/lib/http-proxy/passes/web-incoming.js#L58-L86). Fixes WEB-1064
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new serializable helper struct for Turbopack's server information (
hostname,ip,port,protocol).Testing Instructions
None
Re: WEB-1064