allow to create internal modules via AssetContext #5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
|
✅ This change can build |
|
Linux Benchmark for 8bcd5ceClick to view benchmark
|
…nceType::Internal
|
Is there any reason for us to keep using |
Linux Benchmark for 4861425Click to view benchmark
|
We can't make them private as it's used from |
Linux Benchmark for f1fc798
Click to view full benchmark
|
alexkirsz
approved these changes
May 26, 2023
alexkirsz
approved these changes
May 26, 2023
| use crate::{asset::AssetVc, resolve::ModulePartVc}; | ||
|
|
||
| #[turbo_tasks::value(transparent)] | ||
| pub struct InnerAssets(IndexMap<String, AssetVc>); |
There was a problem hiding this comment.
Add comments to these public structs, explaining why they exist.
| @@ -133,6 +132,62 @@ struct MemoizedSuccessfulAnalysis { | |||
| exports: EcmascriptExportsReadRef, | |||
| } | |||
|
|
|||
| pub struct EcmascriptModuleAssetBuilder { | |||
There was a problem hiding this comment.
Comment this public item and what each argument represents.
There was a problem hiding this comment.
ReferenceType and *ReferenceSubType could #[derive(TaskInput)]. We never use them as Vc anyway.
sokra
added a commit
to vercel/next.js
that referenced
this pull request
May 27, 2023
### What? create internal modules via `context.process` with `ReferenceType::Internal` ### Why? We need this for future refactoring where we want to the internal modules with transitions. ### Turbopack Changes * vercel/turbo#5095 <!-- Tobias Koppers - allow to create internal modules via AssetContext --> * vercel/turbo#5104 <!-- Alex Kirszenberg - Stable chunk list ident --> * vercel/turbo#5106 <!-- Tobias Koppers - followup fix --> --------- Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
### What? create internal modules via `context.process` with `ReferenceType::Internal` ### Why? We need this for future refactoring where we want to the internal modules with transitions. ### Turbopack Changes * vercel/turbo#5095 <!-- Tobias Koppers - allow to create internal modules via AssetContext --> * vercel/turbo#5104 <!-- Alex Kirszenberg - Stable chunk list ident --> * vercel/turbo#5106 <!-- Tobias Koppers - followup fix --> --------- Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows to create an Module with inner asset via AssetContext.
This will also respect transitions.
This change allows use to use
context.process(source, ReferenceType::Internal(inner_assets)instead ofEcmascriptModuleAssetVc::new_with_inner_assets(..., ..., ..., ..., ..., inner_assets)next.js PR: vercel/next.js#50338