Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflow): update turbopack test results to datadog #5107

Merged
merged 1 commit into from
May 27, 2023
Merged

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented May 26, 2023

Description

This PR makes turbopack's test result to be uploaded to datadog for the observability. Datadog have a dedicated test / pipeline features for the CI, we'll going to utilize it.

Once uploaded, individual CI results can be displayed like

image image

and we'll setup a dashboard to refine data what we want to see.

@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 27, 2023 0:12am
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 27, 2023 0:12am
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 27, 2023 0:12am
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 27, 2023 0:12am
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 27, 2023 0:12am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview May 27, 2023 0:12am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 27, 2023 0:12am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview May 27, 2023 0:12am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 27, 2023 0:12am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 27, 2023 0:12am
turbo-site ⬜️ Ignored (Inspect) Visit Preview May 27, 2023 0:12am

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@kwonoj kwonoj force-pushed the test-enable-dd branch 5 times, most recently from 0fc6030 to 88c6d32 Compare May 26, 2023 20:03
@kwonoj kwonoj changed the title [DONOTMERGE] wip ci(workflow): update turbopack test results to datadog May 26, 2023
@kwonoj
Copy link
Contributor Author

kwonoj commented May 26, 2023

Note this won't work currently until we get the proper api key, however CI shouldn't fail.

@kwonoj kwonoj marked this pull request as ready for review May 26, 2023 20:07
@kwonoj kwonoj requested review from a team as code owners May 26, 2023 20:07
@github-actions
Copy link
Contributor

Linux Benchmark for 706df30

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 4665.41µs ± 33.37µs 4644.32µs ± 44.18µs -0.45%
bench_hmr_to_eval/Turbopack CSR/1000 modules 4320.47µs ± 24.87µs 4458.51µs ± 234.60µs +3.20%
bench_startup/Turbopack CSR/1000 modules 708.65ms ± 0.97ms 711.17ms ± 4.54ms +0.36%

@@ -0,0 +1,17 @@
[profile.tp-test-linux.junit]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By using profile local test run won't create redundant reports.

upload_test_results:
name: Upload Test results
needs:
- turbopack_rust_test1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a starting point, only uploads test results. We may expand this to the benchmark results.

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for 63f8b9e

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8528.97µs ± 63.40µs 8613.22µs ± 82.36µs +0.99%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7569.86µs ± 31.95µs 7853.12µs ± 221.61µs +3.74%
bench_startup/Turbopack CSR/1000 modules 877.04ms ± 3.50ms 873.24ms ± 2.65ms -0.43%

@kwonoj kwonoj merged commit d51ad5a into main May 27, 2023
74 of 75 checks passed
@kwonoj kwonoj deleted the test-enable-dd branch May 27, 2023 02:25
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request May 30, 2023
## What

* updates swc_core
* updates turbopack

# Turbopack Changes

* vercel/turbo#5050 
* vercel/turbo#5107 
* vercel/turbo#5094
hydRAnger pushed a commit to hydRAnger/next.js that referenced this pull request Jun 12, 2023
## What

* updates swc_core
* updates turbopack

# Turbopack Changes

* vercel/turbo#5050 
* vercel/turbo#5107 
* vercel/turbo#5094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants