Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(workflow): upload daily next.js test trace #5254

Merged
merged 1 commit into from
Jun 22, 2023
Merged

ci(workflow): upload daily next.js test trace #5254

merged 1 commit into from
Jun 22, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Jun 8, 2023 •
edited

Description

WEB-1194.

This PR revises daily test workflow, and upload traces to datadog. It skips one test affected by #5294, once resolved will be reenabled.

@vercel
Copy link

vercel bot commented Jun 8, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-native-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 5:11pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 5:11pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 5:11pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 5:11pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 5:11pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 5:11pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 5:11pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 5:11pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 5:11pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 5:11pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 5:11pm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)
  • Turbopack Rust benchmark tests (mac/win, non-blocking)

See workflow summary for details

@kwonoj kwonoj force-pushed the refine-daily-test branch 20 times, most recently from c5426ed to dd7255b Compare June 13, 2023 16:42
@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

Linux Benchmark for 2b91746

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9739.25µs ± 81.78µs 9657.37µs ± 89.78µs -0.84%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8805.61µs ± 89.35µs 9055.21µs ± 96.87µs +2.83%
bench_startup/Turbopack CSR/1000 modules 934.52ms ± 3.46ms 936.07ms ± 4.13ms +0.17%

@github-actions
Copy link
Contributor

MacOS Benchmark for 2b91746

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 6284.12ms ± 854.32ms 3194.04ms ± 88.25ms -49.17% -26.33%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.55ms ± 0.15ms 26.96ms ± 0.13ms +1.51%
bench_hmr_to_eval/Turbopack CSR/1000 modules 25.25ms ± 0.38ms 31.16ms ± 3.16ms +23.43%
bench_startup/Turbopack CSR/1000 modules 6284.12ms ± 854.32ms 3194.04ms ± 88.25ms -49.17% -26.33%

@github-actions
Copy link
Contributor

Linux Benchmark for 4c2147b

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 6499.51µs ± 29.25µs 6363.90µs ± 31.52µs -2.09% -0.22%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 6499.51µs ± 29.25µs 6363.90µs ± 31.52µs -2.09% -0.22%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5722.84µs ± 44.29µs 6190.78µs ± 408.64µs +8.18%
bench_startup/Turbopack CSR/1000 modules 811.32ms ± 4.42ms 810.59ms ± 7.00ms -0.09%

@kwonoj kwonoj force-pushed the refine-daily-test branch 2 times, most recently from 1b7cad1 to b8b75c8 Compare June 20, 2023 22:54
@github-actions
Copy link
Contributor

Linux Benchmark for ab1b3fa

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9499.11µs ± 53.75µs 9543.12µs ± 61.84µs +0.46%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8560.99µs ± 59.34µs 8758.09µs ± 293.27µs +2.30%
bench_startup/Turbopack CSR/1000 modules 930.94ms ± 1.64ms 936.40ms ± 4.38ms +0.59%

@github-actions
Copy link
Contributor

Linux Benchmark for 4761a46

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules 9038.74µs ± 81.99µs 9603.78µs ± 118.22µs +6.25% +1.79%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 11.10ms ± 0.12ms 11.08ms ± 0.19ms -0.23%
bench_hmr_to_eval/Turbopack CSR/1000 modules 9038.74µs ± 81.99µs 9603.78µs ± 118.22µs +6.25% +1.79%
bench_startup/Turbopack CSR/1000 modules 996.32ms ± 3.95ms 986.12ms ± 4.08ms -1.02%

@github-actions
Copy link
Contributor

MacOS Benchmark for 4761a46

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 3112.79ms ± 53.39ms 3474.09ms ± 105.88ms +11.61% +1.33%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.44ms ± 0.21ms 26.76ms ± 0.09ms +1.21%
bench_hmr_to_eval/Turbopack CSR/1000 modules 26.41ms ± 0.11ms 26.51ms ± 0.27ms +0.38%
bench_startup/Turbopack CSR/1000 modules 3112.79ms ± 53.39ms 3474.09ms ± 105.88ms +11.61% +1.33%

@kwonoj kwonoj changed the title [DONOTMERGE] WIP ci(workflow): upload daily next.js test trace Jun 21, 2023
@kwonoj kwonoj marked this pull request as ready for review June 21, 2023 01:59
@kwonoj kwonoj requested review from a team as code owners June 21, 2023 01:59
@github-actions
Copy link
Contributor

Linux Benchmark for 788bd53

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 4961.63µs ± 20.03µs 4991.77µs ± 23.55µs +0.61%
bench_hmr_to_eval/Turbopack CSR/1000 modules 4620.29µs ± 25.73µs 4799.77µs ± 180.12µs +3.88%
bench_startup/Turbopack CSR/1000 modules 752.32ms ± 1.35ms 753.29ms ± 2.88ms +0.13%

@kwonoj kwonoj added the pr: automerge Kodiak will merge these automatically after checks pass label Jun 22, 2023
@kwonoj
ci(workflow): upload daily next.js test trace
72b11cd 
Signed-off-by: OJ Kwon <1210596+kwonoj@users.noreply.github.com>
@kwonoj kwonoj merged commit b0649f6 into main Jun 22, 2023
35 checks passed
@kwonoj kwonoj deleted the refine-daily-test branch June 22, 2023 17:20
@github-actions
Copy link
Contributor

Linux Benchmark for cfc0add

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 11.52ms ± 0.10ms 11.52ms ± 0.10ms -0.02%
bench_hmr_to_eval/Turbopack CSR/1000 modules 10.74ms ± 0.11ms 11.44ms ± 0.37ms +6.48%
bench_startup/Turbopack CSR/1000 modules 1173.72ms ± 3.23ms 1167.87ms ± 7.53ms -0.50%

@github-actions
Copy link
Contributor

MacOS Benchmark for cfc0add

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules 26.11ms ± 0.16ms 59.85ms ± 10.68ms +129.21% +45.58%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.27ms ± 0.24ms 27.39ms ± 0.16ms +0.42%
bench_hmr_to_eval/Turbopack CSR/1000 modules 26.11ms ± 0.16ms 59.85ms ± 10.68ms +129.21% +45.58%
bench_startup/Turbopack CSR/1000 modules 3583.66ms ± 59.18ms 3637.69ms ± 100.82ms +1.51%

@sokra sokra mentioned this pull request Jun 22, 2023
Merged
sokra added a commit to vercel/next.js that referenced this pull request Jun 23, 2023
@sokra
add edge rendering for app dir for Turbopack (#51666)
5abeb99 
relanding #50830 and #51631 

### Turbopack Changes

* vercel/turbo#5254 <!-- OJ Kwon - ci(workflow):
upload daily next.js test trace -->
* vercel/turbo#5363 <!-- Tobias Koppers -
disable default features for turbopack-ecmascript-plugins -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

@arlyon arlyon Awaiting requested review from arlyon arlyon is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwonoj @sokra