Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update test runner #5264

Merged
merged 3 commits into from
Jun 12, 2023
Merged

update test runner #5264

merged 3 commits into from
Jun 12, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 10, 2023

Description

new next.js CI depends on these changes.
It's running as root which requires no_sandbox
Also updates the chromiumoxide dependency

Testing Instructions

@sokra sokra requested review from a team as code owners June 10, 2023 10:01
@vercel
Copy link

vercel bot commented Jun 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

11 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jun 10, 2023 10:01am
examples-cra-web ⬜️ Ignored (Inspect) Jun 10, 2023 10:01am
examples-designsystem-docs ⬜️ Ignored (Inspect) Jun 10, 2023 10:01am
examples-gatsby-web ⬜️ Ignored (Inspect) Jun 10, 2023 10:01am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jun 10, 2023 10:01am
examples-native-web ⬜️ Ignored (Inspect) Jun 10, 2023 10:01am
examples-nonmonorepo ⬜️ Ignored (Inspect) Jun 10, 2023 10:01am
examples-svelte-web ⬜️ Ignored (Inspect) Jun 10, 2023 10:01am
examples-tailwind-web ⬜️ Ignored (Inspect) Jun 10, 2023 10:01am
examples-vite-web ⬜️ Ignored (Inspect) Jun 10, 2023 10:01am
turbo-site ⬜️ Ignored (Inspect) Jun 10, 2023 10:01am

@github-actions
Copy link
Contributor

⚠️ This change may fail to build next-swc.

Logs 

error: failed to select a version for `swc_core`.
    ... required by package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=6a2c9c361e11bcd0b3a0d34235f8d6061945beb7#2baad6fa)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-build v0.1.0 (/home/runner/work/turbo/turbo/packages/next-swc/crates/next-build)`
    ... which satisfies path dependency `next-build` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/home/runner/work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^0.76.46` are: 0.76.48, 0.76.47, 0.76.46

all possible versions conflict with previously selected packages.

  previously selected package `swc_core v0.76.41`
    ... which satisfies dependency `swc_core = "^0.76.0"` (locked to 0.76.41) of package `mdxjs v0.1.12`
    ... which satisfies dependency `mdxjs = "^0.1.12"` (locked to 0.1.12) of package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=6a2c9c361e11bcd0b3a0d34235f8d6061945beb7#2baad6fa)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-build v0.1.0 (/home/runner/work/turbo/turbo/packages/next-swc/crates/next-build)`
    ... which satisfies path dependency `next-build` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/home/runner/work/turbo/turbo/packages/next-swc/crates/napi)`

failed to select a version for `swc_core` which could resolve this conflict

See job summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for 6a2c9c3

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9164.63µs ± 64.77µs 9024.85µs ± 47.14µs -1.53%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8243.55µs ± 68.98µs 8088.61µs ± 74.98µs -1.88%
bench_startup/Turbopack CSR/1000 modules 906.24ms ± 1.53ms 905.20ms ± 2.68ms -0.12%

@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2023 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 6c55f3d into main Jun 12, 2023
47 of 50 checks passed
@sokra sokra deleted the sokra/update-chromiumoxide branch June 12, 2023 06:21
@sokra sokra mentioned this pull request Jun 12, 2023
Merged
ijjk added a commit to vercel/next.js that referenced this pull request Jun 12, 2023
@sokra @ijjk
add turbopack integration tests to CI (#50904)
6b0a6f0 
### What?

* enable turbopack tests in new CI
* split pre-build step into native and JS builds to allow to start
native tests faster
* update swc_core to sync with turbo
* update turbopack

### Why?

Running our test suite is still important as long we don't have the full
integration test suite enabled.

### Turbopack updates

* vercel/turbo#5215 <!-- OJ Kwon - ci(workflow):
upload benchmark results to datadog -->
* vercel/turbo#5239 <!-- OJ Kwon -
fix(swc_plugin): use shared runtime -->
* vercel/turbo#3090 <!-- CHEN Yuan - Docs: prior
to run testcases, add guides to install dependencies for testcases. -->
* vercel/turbo#5264 <!-- Tobias Koppers - update
test runner -->

---------

Co-authored-by: JJ Kasper <jj@jjsweb.site>
mehulkar pushed a commit that referenced this pull request Jun 15, 2023
@sokra @mehulkar
update test runner (#5264)
e530684 
### Description

new next.js CI depends on these changes.
It's running as `root` which requires `no_sandbox`
Also updates the chromiumoxide dependency

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sokra