Fix internal JS/TS references not being processed #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
sokra
approved these changes
Jul 4, 2023
Linux Benchmark for 4b79e3fClick to view benchmark
|
This was referenced Jul 4, 2023
MacOS Benchmark for 4b79e3f
Click to view full benchmark
|
alexkirsz
added a commit
that referenced
this pull request
Jul 4, 2023
### Description In #5457, I fixed internal .jsx?/.tsx? references not being processed. However, it turns out we also use `.mjs` for structured images in Next.js, which also use internal references. ### Testing Instructions Next.js CI
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 4, 2023
## Turbopack updates * vercel/turbo#5457 * vercel/turbo#5458
shuding
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 8, 2023
## Turbopack updates * vercel/turbo#5457 * vercel/turbo#5458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My recent change in #5397 added a way to create rules that only apply to internal references. In the process, I also made it so the default rules don't apply to internal references as well. However, we still need them to apply to TS and JS files, as we use that with ReferenceType::Internal in Next.js.
Testing Instructions
Next.js CI