use a lock to ensure atomic invalidation from file changes #5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex Kirszenberg <alexkirsz@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
✅ This change can build |
|
Linux Benchmark for 2b0ed98Click to view benchmark
|
MacOS Benchmark for 2b0ed98
Click to view full benchmark
|
alexkirsz
reviewed
Jul 5, 2023
| /// watcher invalidation and a read lock during other operations. | ||
| #[turbo_tasks(debug_ignore, trace_ignore)] | ||
| #[serde(skip)] | ||
| invalidation_lock: Arc<RwLock<()>>, |
There was a problem hiding this comment.
It feels wrong that this should be a lock on (). Can we use the type system to ensure we can't do this wrong instead? e.g. by having this lock condition access to the other locks?
There was a problem hiding this comment.
I think you're suggesting that we have RwLock<InvalidatorMap>? Which I was going to suggest, too.
Co-authored-by: Alex Kirszenberg <alexkirsz@users.noreply.github.com>
Linux Benchmark for 4b74b2aClick to view benchmark
|
MacOS Benchmark for 4b74b2a
Click to view full benchmark
|
alexkirsz
approved these changes
Jul 6, 2023
feedthejim
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 6, 2023
Depends on vercel/turbo#5398 (and downstack) on the Turbo side. This PR makes it so the output path of Node.js entry chunks for pages is determined solely from the pathname. This isn't actually necessary for pages, but it makes for easier debugging anyway. See the Turbo PR for more details. This also changes the page structure so it also works if there is no `pages` directory. In this case, we still want to use pages' default _app, _document, and _error pages, even with existing app routes. So an empty page structure should still have an effect. ## Turbopack updates * vercel/turbo#5415 <!-- Will Binns-Smith - Turbopack: Execution tests in node.js --> * vercel/turbo#5461 <!-- Tobias Koppers - use a lock to ensure atomic invalidation from file changes --> * vercel/turbo#5398 <!-- Alex Kirszenberg - Configure the path of the Node.js entry chunk --> * vercel/turbo#5469 <!-- Tobias Koppers - allow hmr tests to correctly detect hmr event -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes "app_dir must be a directory" error