Source trait #5483
Merged
Source trait #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
sokra
commented
Jul 10, 2023
| pub start: SourcePos, | ||
| pub end: SourcePos, | ||
| } | ||
|
|
||
| #[turbo_tasks::value_impl] | ||
| impl IssueSourceVc { | ||
| #[turbo_tasks::function] | ||
| pub async fn from_byte_offset(asset: AssetVc, start: usize, end: usize) -> Result<Self> { | ||
| pub async fn from_byte_offset(source: AssetVc, start: usize, end: usize) -> Result<Self> { |
There was a problem hiding this comment.
I wasn't able to change this to SourceVc yet, since it's called also called ModuleVc
|
✅ This change can build |
alexkirsz
approved these changes
Jul 10, 2023
|
Linux Benchmark for 70ebee5Click to view benchmark
|
Windows Benchmark for 70ebee5
Click to view full benchmark
|
Linux Benchmark for c056e49Click to view benchmark
|
Windows Benchmark for c056e49
Click to view full benchmark
|
Linux Benchmark for 9a87dc5
Click to view full benchmark
|
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jul 11, 2023
### What? refactoring see vercel/turbo#5483 ### Turbopack Changes * vercel/turbo#5483 <!-- Tobias Koppers - Source trait -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
next.js PR: vercel/next.js#52511