add reporting of console messages #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
arlyon
approved these changes
Jul 11, 2023
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 12, 2023
This PR adds proof-of-concept support for the App Router to `next build --experimental-turbo`. It introduces a new way to generate Next.js manifests in Turbopack. Currently, in dev, we pass proxy objects in lieu of manifests, and rely on the entries to know which chunks they need loaded on the client. However, this can't work for builds because it requires control over Next.js rendering, which is not compatible with a Next->Turbo approach. We would need to modify Next.js to support these "lazy" entries. So for now, we add well-known assets (`NextDynamicAsset`, `NextServerComponentAsset`, `NextClientReferenceAsset`, etc.) to the graph, which will get picked up when walking it during asset processing. This lets us collect all possible entries before chunking. This two-step process (collecting all entries, then chunking them) is also a good first step towards production chunking. ## Turbopack updates * vercel/turbo#5494 <!-- Tobias Koppers - add reporting of console messages --> * vercel/turbo#5448 <!-- Alex Kirszenberg - Misc. changes to support App Router build -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
report metrics for the number of console output in the browser