feat(turbopack-core): parse query params of resolve requests #5677

ForsakenHarmony · 2023-08-04T19:18:15Z

Description

Testing Instructions

vercel · 2023-08-04T19:18:19Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-basic-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Aug 10, 2023 3:10pm
examples-designsystem-docs	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Aug 10, 2023 3:10pm
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 10, 2023 3:10pm

8 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-cra-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 10, 2023 3:10pm
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 10, 2023 3:10pm
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	Aug 10, 2023 3:10pm
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 10, 2023 3:10pm
examples-nonmonorepo	⬜️ Ignored (Inspect)	Visit Preview	Aug 10, 2023 3:10pm
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 10, 2023 3:10pm
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 10, 2023 3:10pm
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 10, 2023 3:10pm

ForsakenHarmony · 2023-08-04T19:18:27Z

Current dependencies on/for this PR:

main
- PR feat(turbopack-core): parse query params of resolve requests #5677 👈
  - PR feat: support ?module imports for WebAssembly #5660

This comment was auto-generated by Graphite.

github-actions · 2023-08-04T19:22:18Z

✅ This change can build next-swc

github-actions · 2023-08-04T21:37:21Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

crates/turbopack-core/src/ident.rs

github-actions · 2023-08-08T15:38:42Z

Linux Benchmark for `ccbdcf2`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5381.49µs ± 21.08µs	5376.51µs ± 37.17µs	-0.09%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5036.15µs ± 18.29µs	5132.39µs ± 144.41µs	+1.91%
bench_startup/Turbopack CSR/1000 modules	986.97ms ± 1.33ms	990.44ms ± 2.22ms	+0.35%

github-actions · 2023-08-09T16:21:56Z

Linux Benchmark for `adb6834`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	6771.88µs ± 65.21µs	6692.17µs ± 33.17µs	-1.18%
bench_hmr_to_eval/Turbopack CSR/1000 modules	6229.09µs ± 29.46µs	6335.82µs ± 163.36µs	+1.71%
bench_startup/Turbopack CSR/1000 modules	1012.83ms ± 0.98ms	1015.77ms ± 2.41ms	+0.29%

github-actions · 2023-08-09T16:46:57Z

MacOS Benchmark for `adb6834`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.55ms ± 0.13ms	26.78ms ± 0.23ms	-2.81%	-0.24%
bench_hmr_to_eval/Turbopack CSR/1000 modules	24.50ms ± 1.97ms	39.58ms ± 3.92ms	+61.56%	+11.58%
bench_startup/Turbopack CSR/1000 modules	4941.83ms ± 392.19ms	3477.19ms ± 142.36ms	-29.64%	-9.51%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.55ms ± 0.13ms	26.78ms ± 0.23ms	-2.81%	-0.24%
bench_hmr_to_eval/Turbopack CSR/1000 modules	24.50ms ± 1.97ms	39.58ms ± 3.92ms	+61.56%	+11.58%
bench_startup/Turbopack CSR/1000 modules	4941.83ms ± 392.19ms	3477.19ms ± 142.36ms	-29.64%	-9.51%

crates/turbopack-core/src/resolve/mod.rs

github-actions · 2023-08-10T14:39:50Z

Linux Benchmark for `632430e`

Test	Base	PR	%	Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules	5990.75µs ± 84.70µs	5412.54µs ± 93.03µs	-9.65%	-3.83%
bench_startup/Turbopack CSR/1000 modules	1031.63ms ± 2.90ms	1067.74ms ± 10.32ms	+3.50%	+0.93%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	6644.78µs ± 49.91µs	6684.64µs ± 53.53µs	+0.60%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5990.75µs ± 84.70µs	5412.54µs ± 93.03µs	-9.65%	-3.83%
bench_startup/Turbopack CSR/1000 modules	1031.63ms ± 2.90ms	1067.74ms ± 10.32ms	+3.50%	+0.93%

github-actions · 2023-08-10T15:29:03Z

Linux Benchmark for c9a1ca7

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5900.54µs ± 45.89µs	5901.23µs ± 30.06µs	+0.01%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5424.98µs ± 30.79µs	5720.52µs ± 225.10µs	+5.45%
bench_startup/Turbopack CSR/1000 modules	1017.54ms ± 3.86ms	1011.76ms ± 5.92ms	-0.57%

github-actions · 2023-08-10T15:59:33Z

MacOS Benchmark for c9a1ca7

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	3920.50ms ± 266.95ms	13.38s ± 2.07s	+241.33%	+107.36%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.99ms ± 0.12ms	27.60ms ± 0.12ms	-1.39%
bench_hmr_to_eval/Turbopack CSR/1000 modules	26.04ms ± 0.07ms	25.84ms ± 0.29ms	-0.77%
bench_startup/Turbopack CSR/1000 modules	3920.50ms ± 266.95ms	13.38s ± 2.07s	+241.33%	+107.36%

### What? Now that we have wasm support (and support for `?module`) `@vercel/og` should be supported ### Turbopack updates * vercel/turbo#5677 * vercel/turbo#5660 Closes WEB-138

…5677)

ForsakenHarmony requested a review from a team as a code owner August 4, 2023 19:18

turbo-orchestrator bot added the team: turbopack label Aug 4, 2023

ForsakenHarmony mentioned this pull request Aug 4, 2023

feat: support ?module imports for WebAssembly #5660

Merged

vercel bot deployed to Preview – turbo-site August 4, 2023 19:19 View deployment

ForsakenHarmony force-pushed the hrmny/parse-request-query branch from 78f9d74 to 557c13d Compare August 4, 2023 19:29

vercel bot deployed to Preview – turbo-site August 4, 2023 19:30 View deployment

jridgewell approved these changes Aug 5, 2023

View reviewed changes

crates/turbopack-core/src/ident.rs Outdated Show resolved Hide resolved

ForsakenHarmony force-pushed the hrmny/parse-request-query branch from 557c13d to f2ca09c Compare August 7, 2023 17:48

vercel bot deployed to Preview – turbo-site August 7, 2023 17:49 View deployment

ForsakenHarmony requested a review from a team as a code owner August 8, 2023 13:41

ForsakenHarmony requested review from chris-olszewski and NicholasLYang August 8, 2023 13:41

turbo-orchestrator bot added area: ci team: turborepo labels Aug 8, 2023

ForsakenHarmony force-pushed the hrmny/parse-request-query branch from fdb0fac to 132d8aa Compare August 8, 2023 14:56

vercel deleted a comment from github-actions bot Aug 8, 2023

vercel bot deployed to Preview – turbo-site August 8, 2023 14:58 View deployment

This comment was marked as outdated.

Sign in to view

ForsakenHarmony force-pushed the hrmny/parse-request-query branch from 132d8aa to b965647 Compare August 8, 2023 15:21

vercel bot deployed to Preview – turbo-site August 8, 2023 15:22 View deployment

turbo-orchestrator bot removed pkg: turbo-ignore packages/turbo-ignore pkg: turbo-codemod pkg: turbo-gen pkg: turbo-workspaces labels Aug 9, 2023

ForsakenHarmony force-pushed the hrmny/parse-request-query branch from b467b74 to c926f56 Compare August 9, 2023 16:01

vercel bot deployed to Preview – turbo-site August 9, 2023 16:02 View deployment

sokra reviewed Aug 9, 2023

View reviewed changes

crates/turbopack-core/src/resolve/mod.rs Outdated Show resolved Hide resolved

crates/turbopack-core/src/resolve/mod.rs Outdated Show resolved Hide resolved

crates/turbopack-core/src/resolve/mod.rs Show resolved Hide resolved

ForsakenHarmony force-pushed the hrmny/parse-request-query branch from c926f56 to 7524638 Compare August 10, 2023 14:20

vercel bot deployed to Preview – turbo-site August 10, 2023 14:22 View deployment

ForsakenHarmony added 4 commits August 10, 2023 17:05

parse query from imports

4c971de

remove old code

fc3ef72

mirror clippy allow to CI

cc3d8e1

bring back Value wrapping

a97f9c2

ForsakenHarmony force-pushed the hrmny/parse-request-query branch from 7524638 to e5134c3 Compare August 10, 2023 15:05

turbo-orchestrator bot added the area: docs Improvements or additions to documentation label Aug 10, 2023

vercel bot deployed to Preview – turbo-site August 10, 2023 15:07 View deployment

make query a string

4dc656f

ForsakenHarmony force-pushed the hrmny/parse-request-query branch from e5134c3 to 4dc656f Compare August 10, 2023 15:09

turbo-orchestrator bot removed the area: docs Improvements or additions to documentation label Aug 10, 2023

vercel bot deployed to Preview – turbo-site August 10, 2023 15:10 View deployment

ForsakenHarmony merged commit 4c650d6 into main Aug 10, 2023
62 of 63 checks passed

ForsakenHarmony deleted the hrmny/parse-request-query branch August 10, 2023 15:56

ForsakenHarmony mentioned this pull request Aug 11, 2023

enable @vercel/og support for turbopack vercel/next.js#53917

Merged

X-oss-byte pushed a commit to X-oss-byte/turbo that referenced this pull request Aug 29, 2023

feat(turbopack-core): parse query params of resolve requests (vercel#…

34ac1ef

…5677)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(turbopack-core): parse query params of resolve requests #5677

feat(turbopack-core): parse query params of resolve requests #5677

ForsakenHarmony commented Aug 4, 2023

vercel bot commented Aug 4, 2023 •

edited

ForsakenHarmony commented Aug 4, 2023

github-actions bot commented Aug 4, 2023 •

edited

github-actions bot commented Aug 4, 2023 •

edited

This comment was marked as outdated.

github-actions bot commented Aug 8, 2023

github-actions bot commented Aug 9, 2023

github-actions bot commented Aug 9, 2023

github-actions bot commented Aug 10, 2023

github-actions bot commented Aug 10, 2023

github-actions bot commented Aug 10, 2023

feat(turbopack-core): parse query params of resolve requests #5677

feat(turbopack-core): parse query params of resolve requests #5677

Conversation

ForsakenHarmony commented Aug 4, 2023

Description

Testing Instructions

vercel bot commented Aug 4, 2023 • edited

ForsakenHarmony commented Aug 4, 2023

github-actions bot commented Aug 4, 2023 • edited

github-actions bot commented Aug 4, 2023 • edited

⚠️ CI failed ⚠️

This comment was marked as outdated.

github-actions bot commented Aug 8, 2023

Linux Benchmark for ccbdcf2

github-actions bot commented Aug 9, 2023

Linux Benchmark for adb6834

github-actions bot commented Aug 9, 2023

MacOS Benchmark for adb6834

github-actions bot commented Aug 10, 2023

Linux Benchmark for 632430e

github-actions bot commented Aug 10, 2023

Linux Benchmark for c9a1ca7

github-actions bot commented Aug 10, 2023

MacOS Benchmark for c9a1ca7

vercel bot commented Aug 4, 2023 •

edited

github-actions bot commented Aug 4, 2023 •

edited

github-actions bot commented Aug 4, 2023 •

edited

Linux Benchmark for `ccbdcf2`

Linux Benchmark for `adb6834`

MacOS Benchmark for `adb6834`

Linux Benchmark for `632430e`