Transformation code necessary to support Server Actions #5705

jridgewell · 2023-08-11T03:26:09Z

Description

This adds the comments that are added during transforms to out file outputs.

Testing Instructions

cargo nextest run -E 'test(snapshot)'

Closes WEB-1388

vercel · 2023-08-11T03:26:19Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-cra-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Aug 16, 2023 0:23am
examples-nonmonorepo	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Aug 16, 2023 0:23am
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 16, 2023 0:23am

8 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 16, 2023 0:23am
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Aug 16, 2023 0:23am
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 16, 2023 0:23am
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	Aug 16, 2023 0:23am
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 16, 2023 0:23am
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 16, 2023 0:23am
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 16, 2023 0:23am
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 16, 2023 0:23am

github-actions · 2023-08-11T03:30:25Z

✅ This change can build next-swc

github-actions · 2023-08-11T03:35:51Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

github-actions · 2023-08-11T03:43:01Z

Linux Benchmark for `c411ba6`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	989.63ms ± 1.26ms	1000.74ms ± 2.93ms	+1.12%	+0.28%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	5417.83µs ± 22.53µs	5367.15µs ± 29.76µs	-0.94%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5066.53µs ± 10.66µs	5055.48µs ± 43.44µs	-0.22%
bench_startup/Turbopack CSR/1000 modules	989.63ms ± 1.26ms	1000.74ms ± 2.93ms	+1.12%	+0.28%

github-actions · 2023-08-11T04:12:35Z

MacOS Benchmark for `c411ba6`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	14.65s ± 2.09s	3739.62ms ± 158.75ms	-74.47%	-61.28%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.34ms ± 0.17ms	26.74ms ± 0.25ms	-2.21%
bench_hmr_to_eval/Turbopack CSR/1000 modules	26.49ms ± 0.17ms	26.03ms ± 0.15ms	-1.75%
bench_startup/Turbopack CSR/1000 modules	14.65s ± 2.09s	3739.62ms ± 158.75ms	-74.47%	-61.28%

github-actions · 2023-08-11T21:29:05Z

Linux Benchmark for `82c2e3a`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	7042.15µs ± 21.26µs	7046.07µs ± 23.75µs	+0.06%
bench_hmr_to_eval/Turbopack CSR/1000 modules	6400.93µs ± 26.78µs	6753.58µs ± 261.46µs	+5.51%
bench_startup/Turbopack CSR/1000 modules	1044.52ms ± 2.41ms	1060.29ms ± 9.39ms	+1.51%

github-actions · 2023-08-11T21:54:38Z

MacOS Benchmark for `82c2e3a`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.26ms ± 0.07ms	26.85ms ± 0.11ms	-1.50%	-0.18%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.26ms ± 0.07ms	26.85ms ± 0.11ms	-1.50%	-0.18%
bench_hmr_to_eval/Turbopack CSR/1000 modules	26.89ms ± 0.37ms	27.47ms ± 0.21ms	+2.18%
bench_startup/Turbopack CSR/1000 modules	3189.95ms ± 19.94ms	3360.87ms ± 88.86ms	+5.36%

This reverts commit b1b64e2.

github-actions · 2023-08-15T22:45:02Z

Linux Benchmark for `b7a3d26`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5440.96µs ± 12.27µs	5412.31µs ± 40.45µs	-0.53%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5050.90µs ± 31.72µs	5153.56µs ± 114.36µs	+2.03%
bench_startup/Turbopack CSR/1000 modules	996.79ms ± 0.69ms	1003.99ms ± 5.33ms	+0.72%

github-actions · 2023-08-15T23:15:28Z

MacOS Benchmark for `b7a3d26`

Test	Base	PR	%	Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules	22.02ms ± 0.83ms	25.97ms ± 0.22ms	+17.93%	+7.85%
bench_startup/Turbopack CSR/1000 modules	10.26s ± 1.94s	3606.88ms ± 91.05ms	-64.85%	-40.71%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.01ms ± 0.03ms	26.91ms ± 0.20ms	-0.36%
bench_hmr_to_eval/Turbopack CSR/1000 modules	22.02ms ± 0.83ms	25.97ms ± 0.22ms	+17.93%	+7.85%
bench_startup/Turbopack CSR/1000 modules	10.26s ± 1.94s	3606.88ms ± 91.05ms	-64.85%	-40.71%

github-actions · 2023-08-16T00:38:54Z

Linux Benchmark for `80e23de`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5385.88µs ± 16.20µs	5402.50µs ± 15.18µs	+0.31%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5004.94µs ± 25.49µs	5028.85µs ± 14.09µs	+0.48%
bench_startup/Turbopack CSR/1000 modules	992.31ms ± 0.52ms	994.44ms ± 3.84ms	+0.21%

github-actions · 2023-08-16T01:04:12Z

MacOS Benchmark for `80e23de`

Test	Base	PR	%	Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules	23.89ms ± 0.50ms	25.88ms ± 0.26ms	+8.34%	+1.90%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	25.48ms ± 0.17ms	25.79ms ± 0.09ms	+1.19%
bench_hmr_to_eval/Turbopack CSR/1000 modules	23.89ms ± 0.50ms	25.88ms ± 0.26ms	+8.34%	+1.90%
bench_startup/Turbopack CSR/1000 modules	3241.29ms ± 115.36ms	3173.42ms ± 69.59ms	-2.09%

kdy1

Seems like a simple change 😄

jridgewell requested a review from a team as a code owner August 11, 2023 03:26

turbo-orchestrator bot added the team: turbopack label Aug 11, 2023

jridgewell mentioned this pull request Aug 11, 2023

Turbopack: Implement Server Actions vercel/next.js#53890

Merged

jridgewell added 3 commits August 11, 2023 17:00

Add reference to SWC's FileName struct

b1b64e2

Print transformed comments

c673367

Update snapshots

345214d

jridgewell force-pushed the jrl-server-actions branch from 57402d5 to 345214d Compare August 11, 2023 21:12

vercel bot deployed to Preview – turbo-site August 11, 2023 21:13 View deployment

jridgewell added 2 commits August 14, 2023 23:50

Use shallow references during get_referenced_modules graph traversing

a86e2f3

Revert "Add reference to SWC's FileName struct"

8996354

This reverts commit b1b64e2.

turbo-orchestrator bot added created-by: web-tooling team owned-by: turbopack labels Aug 15, 2023

jridgewell requested review from wbinnssmith and kwonoj August 15, 2023 22:28

jridgewell added automated pr: automerge Kodiak will merge these automatically after checks pass and removed automated labels Aug 15, 2023

Merge branch 'main' into jrl-server-actions

12c20c4

vercel bot deployed to Preview – turbo-site August 16, 2023 00:23 View deployment

tknickman removed the created-by: web-tooling team label Aug 16, 2023

turbo-orchestrator bot added the created-by: turbopack label Aug 16, 2023

tknickman removed the team: turbopack label Aug 16, 2023

kdy1 approved these changes Aug 16, 2023

View reviewed changes

kodiakhq bot merged commit f74ff32 into main Aug 16, 2023
47 of 49 checks passed

kodiakhq bot deleted the jrl-server-actions branch August 16, 2023 18:46

wbinnssmith approved these changes Aug 16, 2023

View reviewed changes

sokra mentioned this pull request Aug 25, 2023

update turbopack vercel/next.js#54558

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transformation code necessary to support Server Actions #5705

Transformation code necessary to support Server Actions #5705

jridgewell commented Aug 11, 2023 •

edited

Loading

vercel bot commented Aug 11, 2023 •

edited

Loading

github-actions bot commented Aug 11, 2023 •

edited

Loading

github-actions bot commented Aug 11, 2023 •

edited

Loading

github-actions bot commented Aug 11, 2023

github-actions bot commented Aug 11, 2023

github-actions bot commented Aug 11, 2023

github-actions bot commented Aug 11, 2023

github-actions bot commented Aug 15, 2023

github-actions bot commented Aug 15, 2023

github-actions bot commented Aug 16, 2023

github-actions bot commented Aug 16, 2023

kdy1 left a comment

Transformation code necessary to support Server Actions #5705

Transformation code necessary to support Server Actions #5705

Conversation

jridgewell commented Aug 11, 2023 • edited Loading

Description

Testing Instructions

vercel bot commented Aug 11, 2023 • edited Loading

github-actions bot commented Aug 11, 2023 • edited Loading

github-actions bot commented Aug 11, 2023 • edited Loading

⚠️ CI failed ⚠️

github-actions bot commented Aug 11, 2023

Linux Benchmark for c411ba6

github-actions bot commented Aug 11, 2023

MacOS Benchmark for c411ba6

github-actions bot commented Aug 11, 2023

Linux Benchmark for 82c2e3a

github-actions bot commented Aug 11, 2023

MacOS Benchmark for 82c2e3a

github-actions bot commented Aug 15, 2023

Linux Benchmark for b7a3d26

github-actions bot commented Aug 15, 2023

MacOS Benchmark for b7a3d26

github-actions bot commented Aug 16, 2023

Linux Benchmark for 80e23de

github-actions bot commented Aug 16, 2023

MacOS Benchmark for 80e23de

kdy1 left a comment

Choose a reason for hiding this comment

jridgewell commented Aug 11, 2023 •

edited

Loading

vercel bot commented Aug 11, 2023 •

edited

Loading

github-actions bot commented Aug 11, 2023 •

edited

Loading

github-actions bot commented Aug 11, 2023 •

edited

Loading

Linux Benchmark for `c411ba6`

MacOS Benchmark for `c411ba6`

Linux Benchmark for `82c2e3a`

MacOS Benchmark for `82c2e3a`

Linux Benchmark for `b7a3d26`

MacOS Benchmark for `b7a3d26`

Linux Benchmark for `80e23de`

MacOS Benchmark for `80e23de`