continue on failing test steps #5822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 11 Ignored Deployments
|
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
sokra
commented
Aug 28, 2023
| @@ -34,7 +34,7 @@ jobs: | |||
| upload_test_results: | |||
| name: Upload test results | |||
| needs: [next_js_integration] | |||
| if: ${{ github.event_name == 'schedule' }} | |||
| if: ${{ github.event_name == 'schedule' }} && always() | |||
🟢 CI successful 🟢Thanks |
ForsakenHarmony
approved these changes
Aug 28, 2023
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Aug 30, 2023
* vercel/turbo#5793 <!-- Alex Kirszenberg - Automatically derive ValueDefault for primitive value types --> * vercel/turbo#5784 <!-- Tobias Koppers - make swc comments immutable --> * vercel/turbo#5627 <!-- Tobias Koppers - avoid unnessecary indirection in async modules --> * vercel/turbo#5822 <!-- Tobias Koppers - continue on failing test steps --> * vercel/turbo#5814 <!-- Justin Ridgewell - Update HMR for next-api --> * vercel/turbo#5821 <!-- Tobias Koppers - avoid cloning a large list of task ids --> Closes WEB-1473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
results should still be uploaded when a part of the tests fail or timeout
Closes WEB-1464