Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(examples): upgrade @vercel/style-guide to 5 #5834

Merged
merged 1 commit into from
Aug 29, 2023
Merged

feat(examples): upgrade @vercel/style-guide to 5 #5834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"format": "prettier --write \"**/*.{ts,tsx,md}\""
},
"devDependencies": {
"eslint": "^8.47.0",
"prettier": "^3.0.2",
"eslint": "^8.48.0",
"prettier": "^3.0.3",
"tsconfig": "workspace:*",
"turbo": "^1.10.12"
},
Expand Down
2 changes: 1 addition & 1 deletion examples/basic/packages/eslint-config-custom/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"version": "0.0.0",
"private": true,
"devDependencies": {
"@vercel/style-guide": "^4.0.2",
"@vercel/style-guide": "^5.0.0",
"eslint-config-turbo": "^1.10.12"
}
}
4 changes: 2 additions & 2 deletions examples/basic/packages/eslint-config-custom/react-internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ module.exports = {
},
},
ignorePatterns: ["node_modules/", "dist/", ".eslintrc.js"],
// add rules configurations here

rules: {
"import/no-default-export": "off",
// add specific rules configurations here
},
};
9 changes: 7 additions & 2 deletions examples/basic/packages/ui/button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,13 @@

export function Button(): JSX.Element {
return (
// eslint-disable-next-line no-alert
<button onClick={(): void => alert("booped")} type="button">
<button
onClick={(): void => {
// eslint-disable-next-line no-alert -- alert is being used for demo purposes only
alert("booped");
}}
type="button"
>
Boop
</button>
);
Expand Down
1 change: 1 addition & 0 deletions examples/basic/packages/ui/turbo/generators/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type { PlopTypes } from "@turbo/gen";

// Learn more about Turborepo Generators at https://turbo.build/repo/docs/core-concepts/monorepos/code-generation

// eslint-disable-next-line import/no-default-export -- Turbo generators require default export
export default function generator(plop: PlopTypes.NodePlopAPI): void {
// A simple generator to add a new React component to the internal UI library
plop.setGenerator("react-component", {
Expand Down