Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "normalize pattern correctly to avoid slow path in matching" #6289

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Revert "normalize pattern correctly to avoid slow path in matching" #6289

merged 1 commit into from
Oct 26, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 26, 2023 •
edited by padmaia
Loading

Reverts #6288

Closes WEB-1884

@sokra sokra requested a review from a team as a code owner October 26, 2023 06:41
@vercel
Copy link

vercel bot commented Oct 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

11 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Oct 26, 2023 6:42am
examples-cra-web ⬜️ Ignored (Inspect) Oct 26, 2023 6:42am
examples-designsystem-docs ⬜️ Ignored (Inspect) Oct 26, 2023 6:42am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 6:42am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 6:42am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 6:42am
examples-nonmonorepo ⬜️ Ignored (Inspect) Oct 26, 2023 6:42am
examples-svelte-web ⬜️ Ignored (Inspect) Oct 26, 2023 6:42am
examples-tailwind-web ⬜️ Ignored (Inspect) Oct 26, 2023 6:42am
examples-vite-web ⬜️ Ignored (Inspect) Oct 26, 2023 6:42am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 6:42am

@linear
Copy link

linear bot commented Oct 26, 2023

Issue reopened: WEB-1875 normalize pattern correctly to avoid slow path in matching

@sokra sokra merged commit 26320eb into main Oct 26, 2023
21 checks passed
@sokra sokra deleted the revert-6288-sokra/improve-pattern-performance branch October 26, 2023 06:42
@sokra sokra mentioned this pull request Oct 26, 2023
Merged
@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for 987eb52

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 68.81ms ± 4.81ms 67.60ms ± 5.08ms -1.76%
bench_hmr_to_eval/Turbopack CSR/1000 modules 66.51ms ± 4.99ms 65.44ms ± 4.79ms -1.61%
bench_startup/Turbopack CSR/1000 modules 1074.37ms ± 3.59ms 1074.67ms ± 8.62ms +0.03%

sokra added a commit to vercel/next.js that referenced this pull request Oct 26, 2023
@sokra
update turbopack (#57485)
581b1be 
* vercel/turborepo#6289 <!-- Tobias Koppers - Revert
"normalize pattern correctly to avoid slow path in matching" -->

Closes WEB-1885
@github-actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
Revert "normalize pattern correctly to avoid slow path in matching" (v…
7878a31 
…ercel/turborepo#6289)

Reverts vercel/turborepo#6288

Closes WEB-1884
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
Revert "normalize pattern correctly to avoid slow path in matching" (v…
ec8509e 
…ercel/turborepo#6289)

Reverts vercel/turborepo#6288

Closes WEB-1884
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
Revert "normalize pattern correctly to avoid slow path in matching" (v…
7ad7ebd 
…ercel/turborepo#6289)

Reverts vercel/turborepo#6288

Closes WEB-1884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sokra