chore(turbo-utils): Remove tsup build #6301

mehulkar · 2023-10-27T15:59:37Z

This package does not need to be bundled since it is used only internally in this monorepo. Since we are not publishing it, it does not matter whether it is bundled or not.

package	file	before	after
create-turbo	CJS dist/cli.js	1.21 MB	549.34 KB
turbo-ignore	CJS dist/cli.js	571.73 KB	455.74 KB
eslint-plugin-turbo	CJS dist/index.js	540.35 KB	424.31 KB
@turbo/gen	CJS dist/cli.js	556.05 KB	460.46 KB
@turbo/codemod	CJS dist/cli.js	1.15 MB	379.58 KB
@turbo/workspaces	CJS dist/index.js	523.75 KB	131.29 KB
@turbo/workspaces	CJS dist/cli.js	528.08 KB	126.35 KB
@turbo/workspaces	ESM dist/index.mjs	401.00 B	4.77 KB
@turbo/workspaces	ESM dist/cli.mjs	4.75 KB	412.00 B

Closes TURBO-1542

This package does not need to be bundled since it is used only internally in this monorepo. Since we are not publishing it, it does not matter whether it is bundled or not.

vercel · 2023-10-27T15:59:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-kitchensink-blog	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Nov 2, 2023 5:39pm
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 2, 2023 5:39pm

9 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	Nov 2, 2023 5:39pm
examples-cra-web	⬜️ Ignored (Inspect)	Visit Preview	Nov 2, 2023 5:39pm
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Nov 2, 2023 5:39pm
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview	Nov 2, 2023 5:39pm
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	Nov 2, 2023 5:39pm
examples-nonmonorepo	⬜️ Ignored (Inspect)	Visit Preview	Nov 2, 2023 5:39pm
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Nov 2, 2023 5:39pm
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Nov 2, 2023 5:39pm
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview	Nov 2, 2023 5:39pm

github-actions · 2023-10-27T16:05:05Z

✅ This change can build next-swc

github-actions · 2023-10-27T16:19:39Z

Linux Benchmark for `d6d62c6`

Test	Base	PR	%	Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules	N/A	66.48ms ± 4.76ms	N/A	N/A

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	67.32ms ± 5.49ms	67.22ms ± 5.17ms	-0.15%
bench_hmr_to_eval/Turbopack CSR/1000 modules	N/A	66.48ms ± 4.76ms	N/A	N/A
bench_startup/Turbopack CSR/1000 modules	1071.55ms ± 4.28ms	1067.51ms ± 3.83ms	-0.38%

github-actions · 2023-10-27T16:27:41Z

🟢 Turbopack Benchmark CI successful 🟢

Thanks

github-actions · 2023-10-27T16:29:29Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

tknickman · 2023-10-27T18:22:21Z

Looks good! Let's double check the bundle sizes of packages that are published that depend on this one, but otherwise I'm sold.

mehulkar · 2023-10-27T21:28:23Z

Looks like I had the dist/ dir sitting around for the utils package and hadn't updated the entrypoints in package.json, so it was the same size. after fixing that, i'm actually seeing a dramatic reduction in size of upstream bundles:

package	file	before	after
turbo-ignore:build:	CJS dist/cli.js	571.73 KB	455.74 KB
eslint-plugin-turbo:build:	CJS dist/index.js	540.35 KB	424.31 KB
@turbo/workspaces:build:	CJS dist/index.js	523.75 KB	131.29 KB
@turbo/workspaces:build:	CJS dist/cli.js	528.08 KB	126.35 KB
@turbo/workspaces:build:	ESM dist/index.mjs	401.00 B	4.77 KB
@turbo/workspaces:build:	ESM dist/cli.mjs	4.75 KB	412.00 B
create-turbo:build:	CJS dist/cli.js	1.21 MB	549.34 KB
@turbo/gen:build:	CJS dist/cli.js	556.05 KB	460.46 KB
@turbo/codemod:build:	CJS dist/cli.js	1.15 MB	379.58 KB

github-actions · 2023-10-27T21:48:48Z

Linux Benchmark for `30d5c4f`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	72.24ms ± 5.15ms	74.86ms ± 5.23ms	+3.62%
bench_hmr_to_eval/Turbopack CSR/1000 modules	75.19ms ± 5.09ms	72.40ms ± 5.24ms	-3.71%
bench_startup/Turbopack CSR/1000 modules	1085.05ms ± 4.22ms	1079.40ms ± 7.72ms	-0.52%

github-actions · 2023-11-01T18:52:14Z

Linux Benchmark for `142cdce`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	68.86ms ± 4.98ms	69.12ms ± 5.05ms	+0.38%
bench_hmr_to_eval/Turbopack CSR/1000 modules	68.45ms ± 4.93ms	67.19ms ± 5.26ms	-1.83%
bench_startup/Turbopack CSR/1000 modules	1070.80ms ± 1.54ms	1061.52ms ± 6.38ms	-0.87%

github-actions · 2023-11-01T19:36:31Z

Linux Benchmark for `ea44e5b`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	66.64ms ± 4.71ms	66.52ms ± 5.10ms	-0.19%
bench_hmr_to_eval/Turbopack CSR/1000 modules	64.69ms ± 4.97ms	66.70ms ± 4.52ms	+3.10%
bench_startup/Turbopack CSR/1000 modules	1062.63ms ± 0.98ms	1066.68ms ± 8.06ms	+0.38%

github-actions · 2023-11-02T13:17:57Z

Linux Benchmark for `0b53bea`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	71.24ms ± 4.83ms	71.22ms ± 5.25ms	-0.03%
bench_hmr_to_eval/Turbopack CSR/1000 modules	68.91ms ± 5.46ms	69.10ms ± 4.88ms	+0.27%
bench_startup/Turbopack CSR/1000 modules	1067.23ms ± 2.34ms	1081.18ms ± 7.05ms	+1.31%

github-actions · 2023-11-02T14:40:43Z

Linux Benchmark for `29449cd`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	1054.01ms ± 2.80ms	1069.04ms ± 2.59ms	+1.43%	+0.40%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	70.04ms ± 4.60ms	69.63ms ± 5.07ms	-0.57%
bench_hmr_to_eval/Turbopack CSR/1000 modules	69.07ms ± 5.07ms	69.69ms ± 5.29ms	+0.89%
bench_startup/Turbopack CSR/1000 modules	1054.01ms ± 2.80ms	1069.04ms ± 2.59ms	+1.43%	+0.40%

This reverts commit e56d8f2.

github-actions · 2023-11-02T17:56:07Z

Linux Benchmark for `c025b06`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	67.42ms ± 4.52ms	66.19ms ± 4.90ms	-1.83%
bench_hmr_to_eval/Turbopack CSR/1000 modules	64.52ms ± 4.54ms	63.61ms ± 4.51ms	-1.40%
bench_startup/Turbopack CSR/1000 modules	1061.34ms ± 3.05ms	1051.95ms ± 8.65ms	-0.88%

chore(turbo-utils): Remove tsup build

8db7ab1

This package does not need to be bundled since it is used only internally in this monorepo. Since we are not publishing it, it does not matter whether it is bundled or not.

mehulkar requested a review from a team as a code owner October 27, 2023 15:59

mehulkar requested review from tknickman and NicholasLYang October 27, 2023 15:59

turbo-orchestrator bot added created-by: turborepo owned-by: turborepo labels Oct 27, 2023

vercel bot had a problem deploying to Preview – turbo-site October 27, 2023 16:00 Failure

Merge branch 'main' into mk/rm-tsup-from-utils

0df2122

This comment was marked as outdated.

Sign in to view

Fix entrypoints

a635062

vercel bot deployed to Preview – turbo-site October 27, 2023 21:34 View deployment

Merge branch 'main' into mk/rm-tsup-from-utils

e2d6c59

vercel bot deployed to Preview – examples-vite-web November 1, 2023 16:58 View deployment

vercel bot deployed to Preview – examples-tailwind-web November 1, 2023 16:59 View deployment

vercel bot deployed to Preview – examples-cra-web November 1, 2023 16:59 View deployment

vercel bot deployed to Preview – examples-designsystem-docs November 1, 2023 16:59 View deployment

vercel bot deployed to Preview – examples-svelte-web November 1, 2023 16:59 View deployment

vercel bot deployed to Preview – examples-gatsby-web November 1, 2023 16:59 View deployment

vercel bot deployed to Preview – examples-native-web November 1, 2023 16:59 View deployment

vercel bot deployed to Preview – examples-basic-web November 1, 2023 16:59 View deployment

vercel bot had a problem deploying to Preview – examples-nonmonorepo November 1, 2023 16:59 Failure

vercel bot deployed to Preview – examples-kitchensink-blog November 1, 2023 16:59 View deployment

turbo-orchestrator bot added the pkg: turbo-codemod label Nov 1, 2023

NicholasLYang approved these changes Nov 1, 2023

View reviewed changes

Merge branch 'main' into mk/rm-tsup-from-utils

6db76b4

Merge branch 'main' into mk/rm-tsup-from-utils

273a17f

debug

e56d8f2

mehulkar added 2 commits November 2, 2023 12:36

Revert "debug"

31b56cc

This reverts commit e56d8f2.

Merge branch 'main' into mk/rm-tsup-from-utils

394d6a8

vercel bot deployed to Preview – turbo-site November 2, 2023 17:39 View deployment

mehulkar merged commit 894f932 into main Nov 2, 2023
61 of 64 checks passed

mehulkar deleted the mk/rm-tsup-from-utils branch November 2, 2023 19:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(turbo-utils): Remove tsup build #6301

chore(turbo-utils): Remove tsup build #6301

mehulkar commented Oct 27, 2023 •

edited

vercel bot commented Oct 27, 2023 •

edited

github-actions bot commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

github-actions bot commented Oct 27, 2023 •

edited

github-actions bot commented Oct 27, 2023 •

edited

tknickman commented Oct 27, 2023

This comment was marked as outdated.

mehulkar commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

github-actions bot commented Nov 1, 2023

github-actions bot commented Nov 1, 2023

github-actions bot commented Nov 2, 2023

github-actions bot commented Nov 2, 2023

github-actions bot commented Nov 2, 2023

chore(turbo-utils): Remove tsup build #6301

chore(turbo-utils): Remove tsup build #6301

Conversation

mehulkar commented Oct 27, 2023 • edited

vercel bot commented Oct 27, 2023 • edited

github-actions bot commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

Linux Benchmark for d6d62c6

github-actions bot commented Oct 27, 2023 • edited

🟢 Turbopack Benchmark CI successful 🟢

github-actions bot commented Oct 27, 2023 • edited

⚠️ CI failed ⚠️

tknickman commented Oct 27, 2023

This comment was marked as outdated.

mehulkar commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

Linux Benchmark for 30d5c4f

github-actions bot commented Nov 1, 2023

Linux Benchmark for 142cdce

github-actions bot commented Nov 1, 2023

Linux Benchmark for ea44e5b

github-actions bot commented Nov 2, 2023

Linux Benchmark for 0b53bea

github-actions bot commented Nov 2, 2023

Linux Benchmark for 29449cd

github-actions bot commented Nov 2, 2023

Linux Benchmark for c025b06

mehulkar commented Oct 27, 2023 •

edited

vercel bot commented Oct 27, 2023 •

edited

Linux Benchmark for `d6d62c6`

github-actions bot commented Oct 27, 2023 •

edited

github-actions bot commented Oct 27, 2023 •

edited

Linux Benchmark for `30d5c4f`

Linux Benchmark for `142cdce`

Linux Benchmark for `ea44e5b`

Linux Benchmark for `0b53bea`

Linux Benchmark for `29449cd`

Linux Benchmark for `c025b06`