Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve resolving performance #6304

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 27, 2023

Description

  • read_matches never took the fast path due to a bug in pattern normalization
  • And there was a bug in the fast path anyway

Testing Instructions

Closes WEB-1892

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 7:54am
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 7:54am
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 7:54am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 7:54am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 7:54am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 7:54am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 7:54am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 7:54am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 7:54am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 7:54am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 7:54am

@sokra sokra requested a review from jridgewell October 27, 2023 20:38
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

⚠️ This change may fail to build next-swc.

Logs

packages/next-swc/crates/next-api/src/dynamic_imports.rs:198:49: �[38;5;9merror[E0308]: arguments to this function are incorrect
packages/next-swc/crates/next-api/src/pages.rs:536:41: �[38;5;9merror[E0308]: arguments to this function are incorrect
error: could not compile `next-api` (lib) due to 2 previous errors

See job summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

🟢 CI successful 🟢

Thanks

@github-actions
Copy link
Contributor

Linux Benchmark for 368890f

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 66.50ms ± 4.97ms 64.50ms ± 5.13ms -3.00%
bench_hmr_to_eval/Turbopack CSR/1000 modules 65.62ms ± 4.49ms 63.59ms ± 4.04ms -3.10%
bench_startup/Turbopack CSR/1000 modules 1053.49ms ± 2.86ms 1056.61ms ± 9.93ms +0.30%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Co-authored-by: Leah <github.leah@hrmny.sh>
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Linux Benchmark for 7422dc3

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules N/A 63.31ms ± 4.48ms N/A N/A
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 63.19ms ± 4.90ms 64.23ms ± 4.08ms +1.64%
bench_hmr_to_eval/Turbopack CSR/1000 modules N/A 63.31ms ± 4.48ms N/A N/A
bench_startup/Turbopack CSR/1000 modules 1061.55ms ± 2.25ms 1072.27ms ± 6.97ms +1.01%

@sokra sokra merged commit f903ed5 into main Nov 6, 2023
50 of 51 checks passed
@sokra sokra deleted the sokra/improve-pattern-performance branch November 6, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants