feat: add support for --parallel #6339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
chris-olszewski
requested review from
mehulkar,
Zertsov,
NicholasLYang and
gsoltis
mehulkar
approved these changes
Nov 2, 2023
| @@ -120,6 +120,32 @@ impl PackageGraph { | |||
| Ok(graph::validate_graph(&self.workspace_graph)?) | |||
| } | |||
|
|
|||
| pub fn no_workspace_dependencies(self) -> Self { | |||
There was a problem hiding this comment.
Is remove_workspace_dependencies a better name?
|
|
||
| if let Some(graph_opts) = opts.run_opts.graph { | ||
| match graph_opts { | ||
| GraphOpts::File(graph_file) => { |
There was a problem hiding this comment.
just making sure i understand this arm... it's not actually writing the graph to a file yet right? I don't see the engine or pkg_dep_graph used in here
There was a problem hiding this comment.
Correct, one of the features left is support for non-DOT --graph support. The todo macro call in this branch will panic when hit.
|
|
||
| if !opts.run_opts.parallel { | ||
| engine | ||
| .validate(pkg_dep_graph, opts.run_opts.concurrency) |
There was a problem hiding this comment.
Just a note that we should fix #4291 with this in the future. I think it's fine to only fix in Rust if we're close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR hooks up the correct behavior of
--parallelSome code shuffling happens in the first few commits to get the Rust
runfunction in a closer shape the Go code.Testing Instructions
npx create-turbonpm rm turbobuildscript topackages/ui/package.json:"build": "echo 'building'; sleep 5; echo 'done'",turbo_dev build --parallel --experimental-rust-codepathshould show thatdocs#buildandweb#buildstart beforeui#buildis finished even though they depend on theuiworkspaceCloses TURBO-1566