Turbopack: Implement structured styled text and use it in issue descriptions #6388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iptions This implements a basic structure representing styled text and uses it in issue descriptions. This can be used by the cli and web-based error reporting. Tested with an upcoming Next.js PR
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
Nov 8, 2023
Requires vercel/turbo#6388 This uses the structure implemented in vercel/turbo#6388 to support formatted text when reporting. Right now only the `Line` and basic `String` cases are handled.
kwonoj
reviewed
Nov 8, 2023
| @@ -73,6 +73,41 @@ impl Display for IssueSeverity { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Clone, Debug)] | |||
| #[turbo_tasks::value(shared)] | |||
| pub enum StyledString { | |||
There was a problem hiding this comment.
not going to suggest to make any changes, just random thoughts that if we could just pass raw markdown or formatted text and consumer (next-swc) can transparently renders it'd be cool
kwonoj
reviewed
Nov 8, 2023
|
✅ This change can build |
kwonoj
reviewed
Nov 8, 2023
🟢 CI successful 🟢Thanks |
Linux Benchmark for 225461cClick to view benchmark
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
jridgewell
reviewed
Nov 8, 2023
sokra
reviewed
Nov 8, 2023
sokra
reviewed
Nov 8, 2023
sokra
reviewed
Nov 8, 2023
| @@ -55,7 +56,7 @@ async fn get_update_stream_item( | |||
| plain_issues.push( | |||
| FatalStreamIssue { | |||
| resource: resource.to_string(), | |||
| description: Vc::cell(format!("{}", PrettyPrintError(&e))), | |||
| description: StyledString::String(format!("{}", PrettyPrintError(&e))).cell(), | |||
There was a problem hiding this comment.
We might want a helper to pretty print an error directly into a styled string, so we can use formatting during pretty printing. But that's something for a follow-up PR
sokra
reviewed
Nov 8, 2023
| fn description(&self) -> Vc<String> { | ||
| Vc::cell( | ||
| fn description(&self) -> Vc<StyledString> { | ||
| StyledString::String( | ||
| "React Refresh will be disabled.\nTo enable React Refresh, install the \ | ||
| `react-refresh` and `@next/react-refresh-utils` modules." |
There was a problem hiding this comment.
I would be nice to have a styled! macro that converts markdown to styled string. But that's probably a lot work...
sokra
reviewed
Nov 8, 2023
sokra
reviewed
Nov 8, 2023
sokra
reviewed
Nov 8, 2023
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Linux Benchmark for 1a33186Click to view benchmark
|
Linux Benchmark for 1ac43b8Click to view benchmark
|
Linux Benchmark for 5a8c66dClick to view benchmark
|
Linux Benchmark for ab7a6daClick to view benchmark
|
kdy1
reviewed
Nov 14, 2023
Linux Benchmark for 680691cClick to view benchmark
|
jridgewell
approved these changes
Nov 14, 2023
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 15, 2023
Requires vercel/turbo#6388 This uses the structure implemented in vercel/turbo#6388 to support formatted text when reporting. Right now only the `Line` and basic `String` cases are handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a basic structure representing styled text and uses it in issue descriptions. This can be used by the cli and web-based error reporting.
Tested with an upcoming Next.js PR