Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve count hash set edge case handling, fix negative bottom connection counting #6393

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 8, 2023

Description

There are some bugs when counting negative entries

Testing Instructions

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 9:16am
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 9:16am
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 9:16am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 9:16am
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 9:16am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 9:16am
examples-native-web ⬜️ Ignored (Inspect) Nov 8, 2023 9:16am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 9:16am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 9:16am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 9:16am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 9:16am

Copy link
Contributor

github-actions bot commented Nov 8, 2023

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Nov 8, 2023

🟢 CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Nov 8, 2023

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Linux Benchmark for fab1455

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 64.83ms ± 5.98ms 64.21ms ± 4.93ms -0.96%
bench_hmr_to_eval/Turbopack CSR/1000 modules 62.77ms ± 4.93ms 61.49ms ± 5.07ms -2.04%
bench_startup/Turbopack CSR/1000 modules 1041.36ms ± 3.72ms 1045.37ms ± 4.13ms +0.39%

@sokra sokra requested a review from kwonoj November 8, 2023 09:12
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Linux Benchmark for 3077c46

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 63.60ms ± 5.15ms 62.75ms ± 5.42ms -1.33%
bench_hmr_to_eval/Turbopack CSR/1000 modules 65.67ms ± 4.56ms 64.17ms ± 4.84ms -2.29%
bench_startup/Turbopack CSR/1000 modules 1040.51ms ± 4.45ms 1048.85ms ± 7.47ms +0.80%

@sokra sokra requested a review from jridgewell November 8, 2023 14:09
@sokra sokra merged commit ec0fdf4 into main Nov 8, 2023
53 of 54 checks passed
@sokra sokra deleted the sokra/count-hash-set branch November 8, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants