Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Turborepo): Fix error stutter, update tests to match on relevent error text #6421

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix(Turborepo): Fix error stutter, update tests to match on relevent error text #6421

merged 1 commit into from
Nov 13, 2023

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Nov 10, 2023 •
edited

Description

  • Drop error stutter from Go
  • Update tests to no longer expect duplicate errors
  • top-level rust main no longer prints turbo error for errors from run
  • Update a few tests to match on specific error text to handle errors always coming from Rust, even when we're executing Go

Testing Instructions

Updated integration tests

Closes TURBO-1626

@vercel Vercel
Copy link

vercel bot commented Nov 10, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

11 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Nov 10, 2023 0:41am
examples-cra-web ⬜️ Ignored (Inspect) Nov 10, 2023 0:41am
examples-designsystem-docs ⬜️ Ignored (Inspect) Nov 10, 2023 0:41am
examples-gatsby-web ⬜️ Ignored (Inspect) Nov 10, 2023 0:41am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Nov 10, 2023 0:41am
examples-native-web ⬜️ Ignored (Inspect) Nov 10, 2023 0:41am
examples-nonmonorepo ⬜️ Ignored (Inspect) Nov 10, 2023 0:41am
examples-svelte-web ⬜️ Ignored (Inspect) Nov 10, 2023 0:41am
examples-tailwind-web ⬜️ Ignored (Inspect) Nov 10, 2023 0:41am
examples-vite-web ⬜️ Ignored (Inspect) Nov 10, 2023 0:41am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2023 0:41am

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 10, 2023 •
edited

🟢 CI successful 🟢

Thanks

@gsoltis gsoltis marked this pull request as ready for review November 10, 2023 03:23
@gsoltis gsoltis requested a review from a team as a code owner November 10, 2023 03:23
@gsoltis gsoltis merged commit cf00366 into main Nov 13, 2023
61 of 62 checks passed
@gsoltis gsoltis deleted the gsoltis/error_stutter branch November 13, 2023 19:21
@kdy1 kdy1 mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang

Assignees
No one assigned
Labels
created-by: turborepo owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsoltis @chris-olszewski