Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository -> PackageManagerRoot #6441

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Repository -> PackageManagerRoot #6441

merged 3 commits into from
Nov 17, 2023

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Nov 14, 2023

Description

  • Rename Repository to PackageManagerRoot
  • factory method renamed to find

Testing Instructions

Updated tests

Closes TURBO-1653

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 1:23am
examples-cra-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 1:23am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 1:23am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 1:23am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 1:23am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 1:23am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 1:23am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 1:23am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 1:23am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 1:23am
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 1:23am

Copy link
Contributor

github-actions bot commented Nov 14, 2023

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Nov 14, 2023

🟢 CI successful 🟢

Thanks

@gsoltis gsoltis marked this pull request as ready for review November 14, 2023 17:30
@gsoltis gsoltis requested review from a team as code owners November 14, 2023 17:30
@@ -1,17 +1,17 @@
import * as path from "node:path";
import { Repository } from "../js/dist/index.js";
import { PackageManagerRoot } from "../js/dist/index.js";

describe("detect", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to change this and the test file name also?

@gsoltis gsoltis deleted the gsoltis/repo_rename branch November 17, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants