port(Turborepo): Add github prefixing in Rust #6471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
chris-olszewski
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Approving since we're moving quick, but I do think we can keep the turborepo-ui crate focused on just outputting stuff and not make it aware of CI vendors.
Very much looking forward to eventually getting #6314 merged in post-port.
crates/turborepo-ui/src/output.rs
Outdated
Comment on lines
19
to
32
| pub enum Fenceposts { | ||
| Github(String), | ||
| } | ||
|
|
||
| impl Fenceposts { | ||
| fn prefix_suffix(&self) -> (Option<String>, Option<String>) { | ||
| match self { | ||
| Self::Github(task_name) => ( | ||
| Some(format!("::group::{task_name}\n")), | ||
| Some("::endgroup::\n".to_string()), | ||
| ), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This feels like this belongs in the turborepo-ci crate instead of here.
Comment on lines
102
to
104
| pub fn as_github_task_id(&self) -> String { | ||
| format!("{}:{}", self.package, self.task) | ||
| } |
There was a problem hiding this comment.
Won't die on this hill, but this doesn't feel like it needs to be defined on TaskId, I think it would better be defined as a function in turborepo-ci maybe on the Vendor type.
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slightly hacky way of doing this. It's a little expandable for more providers, but not all of the way. Getting all the way will require a larger output refactor.
Testing Instructions
Updated test for absolute paths in errors
Closes TURBO-1640