feat(ecmascript): support dynamic tenary operator jsvalue #6498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
Linux Benchmark for 1b48f6cClick to view benchmark
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
kwonoj
commented
Nov 17, 2023
| @@ -469,9 +469,11 @@ pub fn replace_builtin(value: &mut JsValue) -> bool { | |||
| if test.is_truthy() == Some(true) { | |||
| *value = take(cons); | |||
| true | |||
| } else { | |||
| } else if test.is_falsy() == Some(true) { | |||
There was a problem hiding this comment.
This was the culprit for the benchmark regresssion;
previously skipping falsy branching per #6452 (comment), however in that case non-truhy dynamic (i.e rootElement === null) is also considered as statically falsy and takes alt directly.
kwonoj
changed the title
Linux Benchmark for decec71Click to view benchmark
|
sokra
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PACK-1963
Reattempt #6452
Closes PACK-1983