Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle dynamic imports when chunk loading is disabled #6499

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 17, 2023

Description

When chunk loading is disable, dynamic imports will just bundle all referenced modules instead of created in separate chunk group

Testing Instructions

Closes PACK-1984

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

11 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Nov 17, 2023 9:07am
examples-cra-web ⬜️ Ignored (Inspect) Nov 17, 2023 9:07am
examples-designsystem-docs ⬜️ Ignored (Inspect) Nov 17, 2023 9:07am
examples-gatsby-web ⬜️ Ignored (Inspect) Nov 17, 2023 9:07am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Nov 17, 2023 9:07am
examples-native-web ⬜️ Ignored (Inspect) Nov 17, 2023 9:07am
examples-nonmonorepo ⬜️ Ignored (Inspect) Nov 17, 2023 9:07am
examples-svelte-web ⬜️ Ignored (Inspect) Nov 17, 2023 9:07am
examples-tailwind-web ⬜️ Ignored (Inspect) Nov 17, 2023 9:07am
examples-vite-web ⬜️ Ignored (Inspect) Nov 17, 2023 9:07am
turbo-site ⬜️ Ignored (Inspect) Nov 17, 2023 9:07am

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Nov 17, 2023

🟢 CI successful 🟢

Thanks

Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

Linux Benchmark for 2ffe5a7

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 22.81ms ± 0.97ms 22.55ms ± 0.96ms -1.12%
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.17ms ± 0.89ms 22.40ms ± 0.92ms +1.06%
bench_startup/Turbopack CSR/1000 modules 1153.53ms ± 13.12ms 1133.60ms ± 8.19ms -1.73%

@sokra sokra merged commit 338e264 into main Nov 17, 2023
54 checks passed
@sokra sokra deleted the sokra/dynamic-import-without-chunk-loading branch November 17, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants