Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with-docker example. #6547

Merged
merged 10 commits into from
Nov 24, 2023
Merged

Update with-docker example. #6547

merged 10 commits into from
Nov 24, 2023

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Nov 22, 2023 •
edited
Loading

Updating the with-docker example!

Closes TURBO-1707

Things to pay attention to:

  • Is tasking correct? Are all tasks successful out-of-the-box? Do I hit cache when I'm expecting?
  • If I add an unused variable in a workspace, do I see a warning in both my editor and when I run turbo lint?
  • Does auto-importing work across packages?
  • Anything else wonky in your editor?
  • Do I get proper hot-reloading in turbo dev?
  • Anything else that may come up!

@anthonyshew anthonyshew requested a review from a team as a code owner November 22, 2023 18:33
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples owned-by: turborepo labels Nov 22, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 10:08pm
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 10:08pm
turbo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 10:08pm
turbo-turbo-tracing-next-plugin ❌ Failed (Inspect) Nov 24, 2023 10:08pm
turbo-with-mongodb-mongoose ❌ Failed (Inspect) Nov 24, 2023 10:08pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 10:08pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 10:08pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 10:08pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 10:08pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 10:08pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 10:08pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 10:08pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 10:08pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 10:08pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

chris-olszewski
chris-olszewski approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chris-olszewski chris-olszewski mentioned this pull request Nov 24, 2023
Merged
6 tasks
@anthonyshew anthonyshew enabled auto-merge (squash) November 24, 2023 22:17
@anthonyshew anthonyshew merged commit 3ddfa0e into main Nov 24, 2023
54 checks passed
@anthonyshew anthonyshew deleted the update-with-docker branch November 24, 2023 22:33
@renovate renovate bot mentioned this pull request Dec 11, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@gsoltis gsoltis Awaiting requested review from gsoltis gsoltis is a code owner automatically assigned from vercel/turbo-oss

@arlyon arlyon Awaiting requested review from arlyon arlyon is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: examples Improvements or additions to examples owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anthonyshew @chris-olszewski