Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix rustdoc build #6599

Merged
merged 1 commit into from
Nov 27, 2023
Merged

docs: Fix rustdoc build #6599

merged 1 commit into from
Nov 27, 2023

Conversation

NicholasLYang
Copy link
Contributor

@NicholasLYang NicholasLYang commented Nov 27, 2023

Description

Ignores the error code on the rustdoc build because we have the --keep-going flag set. Also skips the Go binary build for docs

Testing Instructions

Closes TURBO-1767

Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rust-docs ✅ Ready (Inspect) Visit Preview Nov 27, 2023 8:32pm
turbo-site ✅ Ready (Inspect) Visit Preview Nov 27, 2023 8:32pm
9 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Nov 27, 2023 8:32pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Nov 27, 2023 8:32pm
examples-gatsby-web ⬜️ Ignored (Inspect) Nov 27, 2023 8:32pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Nov 27, 2023 8:32pm
examples-native-web ⬜️ Ignored (Inspect) Nov 27, 2023 8:32pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Nov 27, 2023 8:32pm
examples-svelte-web ⬜️ Ignored (Inspect) Nov 27, 2023 8:32pm
examples-tailwind-web ⬜️ Ignored (Inspect) Nov 27, 2023 8:32pm
examples-vite-web ⬜️ Ignored (Inspect) Nov 27, 2023 8:32pm

Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

Linux Benchmark for 3cdc1a2

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 22.33ms ± 0.93ms 22.33ms ± 0.88ms -0.00%
bench_hmr_to_eval/Turbopack CSR/1000 modules 21.97ms ± 0.89ms 21.73ms ± 0.90ms -1.09%
bench_startup/Turbopack CSR/1000 modules 1103.99ms ± 7.65ms 1140.82ms ± 20.29ms +3.34%

Copy link
Contributor

github-actions bot commented Nov 27, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@NicholasLYang NicholasLYang merged commit 67bea16 into main Nov 27, 2023
61 of 65 checks passed
@NicholasLYang NicholasLYang deleted the docs/rustdoc-fixes branch November 27, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants