fix(turbopack-ecmascript-runtime): don't use path.relative for absolute paths
#6731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
Linux Benchmark for f7f163d
Click to view full benchmark
|
ForsakenHarmony
force-pushed
the
hrmny/absolute-paths-in-workspace
branch
from
f430877
to
953b0d3
Compare
Linux Benchmark for 89b84f2Click to view benchmark
|
kwonoj
approved these changes
Dec 7, 2023
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Dec 8, 2023
### What? Update SWC crates. ### Why? To fix OOM bug of `inputSourceMap`. Patch: swc-project/swc#8402 ### How? Closes PACK-2123 # Turbopack updates * vercel/turbo#6733 <!-- Thomas Knickman - chore(ignore): exclude rustic-ice files --> * vercel/turbo#6731 <!-- Leah - fix(turbopack-ecmascript-runtime): don't use `path.relative` for absolute paths --> * vercel/turbo#6745 <!-- Donny/강동윤 - Update `swc_core` to `v0.86.98` -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was causing an issue with
import.meta.urlused in@vercel/ogtrying to get the font file fromproject/app/node_modulesinstead ofproject/node_modulesPassing all next.js tests: vercel/next.js#59380
Closes PACK-2118