Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clippy 'errors' #6881

Merged
merged 1 commit into from
Jan 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crates/turborepo-filewatch/src/package_watcher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -337,8 +337,8 @@ mod test {
use tokio::sync::broadcast;
use turbopath::AbsoluteSystemPathBuf;
use turborepo_repository::{
discovery::{self, DiscoveryResponse, PackageDiscovery, WorkspaceData},
package_manager::{self, PackageManager},
discovery::{self, DiscoveryResponse, WorkspaceData},
package_manager::PackageManager,
};

use super::Subscriber;
Expand All @@ -352,7 +352,7 @@ mod test {
impl super::PackageDiscovery for MockDiscovery {
async fn discover_packages(&mut self) -> Result<DiscoveryResponse, discovery::Error> {
Ok(DiscoveryResponse {
package_manager: self.manager.clone(),
package_manager: self.manager,
workspaces: self.package_data.lock().unwrap().clone(),
})
}
Expand Down Expand Up @@ -400,7 +400,7 @@ mod test {
.unwrap();

let mock_discovery = MockDiscovery {
manager: manager.clone(),
manager,
package_data: Arc::new(Mutex::new(package_data)),
};

Expand Down Expand Up @@ -533,7 +533,7 @@ mod test {
let package_data_raw = Arc::new(Mutex::new(package_data));

let mock_discovery = MockDiscovery {
manager: manager.clone(),
manager,
package_data: package_data_raw.clone(),
};

Expand Down
3 changes: 2 additions & 1 deletion crates/turborepo-lib/src/process/child.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
/// channel when the child process exits.
async fn process(&self, child: &mut tokio::process::Child) -> ChildState {
match self {
ShutdownStyle::Graceful(timeout) => {

Check warning on line 87 in crates/turborepo-lib/src/process/child.rs

View workflow job for this annotation

GitHub Actions / Build Turborepo (windows, windows-latest)

unused variable: `timeout`

Check warning on line 87 in crates/turborepo-lib/src/process/child.rs

View workflow job for this annotation

GitHub Actions / Turborepo Integration (windows-latest)

unused variable: `timeout`

Check warning on line 87 in crates/turborepo-lib/src/process/child.rs

View workflow job for this annotation

GitHub Actions / Turborepo Integration (Go Fallback) (windows-latest)

unused variable: `timeout`
// try ro run the command for the given timeout
#[cfg(unix)]
{
Expand Down Expand Up @@ -784,9 +784,10 @@
});
}

while let Some(_) = tokio::time::timeout(Duration::from_secs(5), stops.next())
while tokio::time::timeout(Duration::from_secs(5), stops.next())
.await
.expect("timed out")
.is_some()
{}
}
}
Loading