fix(turbo): validate graph extension

crates/turborepo-lib/src/cli/mod.rs

@@ -40,6 +40,8 @@ pub const INVOCATION_DIR_ENV_VAR: &str = "TURBO_INVOCATION_DIR";
 
 // Default value for the --cache-workers argument
 const DEFAULT_NUM_WORKERS: u32 = 10;
+const SUPPORTED_GRAPH_FILE_EXTENSIONS: [&str; 8] =
+    ["svg", "png", "jpg", "pdf", "json", "html", "mermaid", "dot"];
 
 #[derive(Copy, Clone, Debug, PartialEq, Eq, Deserialize, Serialize, ValueEnum)]
 pub enum OutputLogsMode {
@@ -580,6 +582,23 @@ pub enum GenerateCommand {
     Run(GeneratorCustomArgs),
 }
 
+fn validate_graph_extension(s: &str) -> Result<String, String> {
+    match s.is_empty() {
+        true => Ok(s.to_string()),
+        _ => match Utf8Path::new(s).extension() {
+            Some(ext) if SUPPORTED_GRAPH_FILE_EXTENSIONS.contains(&ext) => Ok(s.to_string()),
+            Some(ext) => Err(format!(
+                "Invalid file extension: '{}'. Allowed extensions are: {:?}",
+                ext, SUPPORTED_GRAPH_FILE_EXTENSIONS
+            )),
+            None => Err(format!(
+                "The provided filename is missing a file extension. Allowed extensions are: {:?}",
+                SUPPORTED_GRAPH_FILE_EXTENSIONS
+            )),
+        },
+    }
+}
+
 #[derive(Parser, Clone, Debug, Default, Serialize, PartialEq)]
 #[command(groups = [
     ArgGroup::new("daemon-group").multiple(false).required(false),
@@ -621,8 +640,9 @@ pub struct RunArgs {
     pub global_deps: Vec<String>,
     /// Generate a graph of the task execution and output to a file when a
     /// filename is specified (.svg, .png, .jpg, .pdf, .json,
-    /// .html). Outputs dot graph to stdout when if no filename is provided
-    #[clap(long, num_args = 0..=1, default_missing_value = "")]
+    /// .html, .mermaid, .dot). Outputs dot graph to stdout when if no filename
+    /// is provided
+    #[clap(long, num_args = 0..=1, default_missing_value = "", value_parser = validate_graph_extension)]
     pub graph: Option<String>,
     /// Environment variable mode.
     /// Use "loose" to pass the entire existing environment.
@@ -823,7 +843,9 @@ impl RunArgs {
         }
 
         if let Some(graph) = &self.graph {
-            telemetry.track_arg_value("graph", graph, EventType::NonSensitive);
+            // track the extension used only
+            let extension = Utf8Path::new(graph).extension().unwrap_or("stdout");
+            telemetry.track_arg_value("graph", extension, EventType::NonSensitive);
         }
 
         if self.env_mode != EnvMode::default() {

turborepo-tests/integration/tests/run/graph.t

@@ -33,3 +33,11 @@ Graph to stdout
   graph TD
   \\t[A-Z]{4}\("my-app#build"\) --> [A-Z]{4}\("util#build"\).* (re)
   \\t[A-Z]{4}\("util#build"\) --> [A-Z]{4}\("___ROOT___"\).* (re)
+
+  $ ${TURBO} build -F my-app --graph=graph.mdx
+   ERROR  invalid value 'graph.mdx' for '--graph [<GRAPH>]': Invalid file extension: 'mdx'. Allowed extensions are: ["svg", "png", "jpg", "pdf", "json", "html", "mermaid", "dot"]
+
+  For more information, try '--help'.
+
+  [1]
+