add support for dynamic requests in require() and import() #7153
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
sokra
force-pushed
the
sokra/dynamic-request
branch
from
a4b8e3b
to
53f2bef
Compare
sokra
force-pushed
the
sokra/dynamic-request
branch
from
53f2bef
to
dd4f59b
Compare
sokra
force-pushed
the
sokra/dynamic-request
branch
from
dd4f59b
to
f472811
Compare
sokra
force-pushed
the
sokra/dynamic-request
branch
from
f472811
to
0be21e5
Compare
sokra
force-pushed
the
sokra/dynamic-request
branch
from
0be21e5
to
541fc3e
Compare
crates/turbopack-ecmascript-runtime/js/src/shared/runtime-utils.ts
Outdated
Show resolved
Hide resolved
| }; | ||
| match args.into_iter().next() { | ||
| Some(ExprOrSpread { spread: None, expr: key_expr }) => { | ||
| *expr = pm.create_import(*key_expr, import_externals); |
There was a problem hiding this comment.
It would be nice if pm.create_import could return a CallExpr so we could still use the visit_mut_call_expr visitor
There was a problem hiding this comment.
Technically possible, but not sure if I want to put so much internal knowledge into the signature...
| return Promise.resolve().then(() => { | ||
| throw e; | ||
| }); |
There was a problem hiding this comment.
| return Promise.resolve().then(() => { | |
| throw e; | |
| }); | |
| return Promise.reject(e); |
There was a problem hiding this comment.
That's different. Promise.reject causes an unhandled rejection, but promise resolve throw allows to register a catch before the promise is rejected
There was a problem hiding this comment.
This doesn't seem to be the case?
You can try running this in node.js:
const process = require('node:process');
process.on('unhandledRejection', (reason, promise) => {
console.log('Unhandled Rejection at:', promise, 'reason:', reason);
});
function willReject() {
return Promise.reject(new Error("rejected with error"))
}
async function willCatch() {
try {
await willReject()
} catch(e) {
console.error("caught in try catch", e)
}
}
willReject().catch((err) => console.error("caught in handler", err))
willCatch()
| * flags: | ||
| * * 1: Error as rejected promise | ||
| */ | ||
| function moduleLookup( |
There was a problem hiding this comment.
maybe we can actually just combine this with requireContext?
(for import we could add another property)
just need to copy the generic error from here and maybe expand commonJsRequireContext in place instead of having it as a separate thing
There was a problem hiding this comment.
Yeah we should combine them. In a followup PR?
There was a problem hiding this comment.
I guess we can do that, will change all the snapshots again I guess
sokra
force-pushed
the
sokra/dynamic-request
branch
from
541fc3e
to
944df3d
Compare
sokra
force-pushed
the
sokra/dynamic-request
branch
from
97acf54
to
b20d452
Compare
Description
Refactors
PatternMatchingto support a map of multiple matches by key. Based on the newRequestKeysupport for resolving.Code Generation for
require("./dir/"+ expr)will emit a map of__turbopack_lookup__({ "./a": () => ..., "./b": () => ... }, "./dir/" + expr).The output format isn't really optimized yet, that's work for future PRs.
Testing Instructions
added a test case, enabled one previously skipped test case
Closes PACK-986