feat(turborepo): Daemon package watch #7183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
arlyon
force-pushed
the
feat/daemon-package-watch
branch
from
1adebd5
to
ff203c0
Compare
arlyon
force-pushed
the
feat/daemon-package-watch
branch
from
ff203c0
to
d02a644
Compare
|
Would this be able to be used as a way to trigger tasks when files changes in dependencies/dependents of workspaces? A bit like what |
|
The same infrastructure can definitely be used for alerting the client about package changes but this PR is scoped to relieving the client of having to calculate hashes and speeding up 'time to first task'. The streaming grpc api is just a stub for now. |
arlyon
force-pushed
the
feat/daemon-package-watch
branch
from
939a0a7
to
0b5335a
Compare
arlyon
force-pushed
the
feat/daemon-package-watch
branch
from
0b5335a
to
afa8e69
Compare
arlyon
force-pushed
the
feat/daemon-package-watch
branch
from
58bea99
to
77abbbd
Compare
arlyon
force-pushed
the
feat/daemon-package-watch
branch
from
522d11c
to
38050c0
Compare
gsoltis
force-pushed
the
feat/daemon-package-watch
branch
from
15134d1
to
550d723
Compare
added 2 commits
March 1, 2024 15:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the daemon to watch for package changes and eagerly update hashes. Each package / task maintains a list of hashes that are updated by a file watcher. When turbo launches, it queries that daemon instead of manually walking.
Testing Instructions
Added a subcommand
turbo daemon hash <task>that lets us test the daemon hashing codeCloses TURBO-2200