Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clippy strikes again #7438

Merged
merged 1 commit into from
Feb 20, 2024
Merged

chore: Clippy strikes again #7438

merged 1 commit into from
Feb 20, 2024

Conversation

Zertsov
Copy link
Contributor

@Zertsov Zertsov commented Feb 20, 2024

Description

Clippy be clippin

Closes TURBO-2399

@Zertsov Zertsov requested review from a team as code owners February 20, 2024 17:04
Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 6:47pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 6:47pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 6:47pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 6:47pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 6:47pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 6:47pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 6:47pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 6:47pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 6:47pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 6:47pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 6:47pm

Copy link
Contributor Author

Zertsov commented Feb 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Zertsov and the rest of your teammates on Graphite Graphite

Copy link
Contributor

github-actions bot commented Feb 20, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Feb 20, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@ForsakenHarmony
Copy link
Member

the clippy CI check is broken (maybe cargo-groups is broken)
maybe we should just have one central clippy action without cargo-groups

@@ -1084,7 +1084,6 @@ mod tests {

use build_fs_tree::{dir, file, Build, FileSystemTree};
use path_slash::PathBufExt;
use regex::Regex;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a conditional below that needs it, you'll need to move it in there

@Zertsov Zertsov merged commit 306f130 into main Feb 20, 2024
56 of 57 checks passed
@Zertsov Zertsov deleted the voz/clippy branch February 20, 2024 19:18
Copy link
Contributor Author

Zertsov commented Feb 20, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants