feat(node): augment webpack loader's logger context #7726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
✅ This change can build |
|
| @@ -333,7 +333,7 @@ const transform = ( | |||
| emitWarning: makeErrorEmitter("warning", ipc), | |||
| emitError: makeErrorEmitter("error", ipc), | |||
| getLogger(name: unknown) { | |||
| return (type: unknown, args: unknown) => { | |||
| const logger = (type: unknown, args: unknown) => { | |||
There was a problem hiding this comment.
Would prefer this to not be an arrow function, but it actually uses this so it would need additional changes.
ForsakenHarmony
approved these changes
Mar 13, 2024
kwonoj
force-pushed
the
augment-logger-context
branch
from
8b8ae4f
to
5006dde
Compare
🟢 Turbopack Benchmark CI successful 🟢Thanks |
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Mar 14, 2024
# Turbopack changes * vercel/turbo#7726 <!-- OJ Kwon - feat(node): augment webpack loader's logger context --> * vercel/turbo#7729 <!-- Donny/강동윤 - Update `swc_core` to `v0.90.22` -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to support sass-loader to not fail if it requires specific logger from loadercontext.
Closes PACK-2737