Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(turbopack): Support marking packages as side-effect-free #7731

Merged
merged 16 commits into from
Mar 28, 2024
Merged

feat(turbopack): Support marking packages as side-effect-free #7731

merged 16 commits into from
Mar 28, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 14, 2024 •
edited

Description

This is required to support experimental.optimizePackageImports of next.config.js.

next.js counterpart: vercel/next.js#63268

Closes PACK-2527

Testing Instructions

Look at the test case I added to vercel/next.js#63268

@kdy1 kdy1 self-assigned this Mar 14, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 14, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 5:23am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 5:23am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 5:23am
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 5:23am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 5:23am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 5:23am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 5:23am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 5:23am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 5:23am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 5:23am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 14, 2024 •
edited

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 14, 2024 •
edited

🟢 CI successful 🟢

Thanks

@kdy1 kdy1 mentioned this pull request Mar 14, 2024
Merged
@kdy1
Copy link
Member Author

kdy1 commented Mar 14, 2024

Repro works.

https://github.com/kdy1/repro-pack-2527

image

@kdy1 kdy1 marked this pull request as ready for review March 14, 2024 06:32
@kdy1 kdy1 requested a review from a team as a code owner March 14, 2024 06:32
@kdy1 kdy1 requested a review from sokra March 19, 2024 12:53
@kdy1 kdy1 merged commit ad6b88b into main Mar 28, 2024
50 checks passed
@kdy1 kdy1 deleted the kdy1/pack-2527 branch March 28, 2024 07:37
wbinnssmith added a commit that referenced this pull request Mar 28, 2024
@wbinnssmith
Revert "feat(turbopack): Support marking packages as side-effect-free (…
9707600 
…#7731)"

This reverts commit ad6b88b.
wbinnssmith added a commit that referenced this pull request Mar 28, 2024
@wbinnssmith
Revert "feat(turbopack): Support marking packages as side-effect-free (…
060a146 
…#7731)" (#7861)

This reverts commit ad6b88b.


Closes PACK-2869
kdy1 added a commit that referenced this pull request Mar 29, 2024
@kdy1
Revert "Revert "feat(turbopack): Support marking packages as side-eff…
4190173 
…ect-free (#7731)" (#7861)"

This reverts commit 060a146.
kdy1 added a commit to vercel/next.js that referenced this pull request Mar 29, 2024
@kdy1
feat(next-swc): Pass names of side-effect-free packages (#63268)
29d53c8 
### What?

Pass the names of side-effect-free packages specified in `experimental.optimizePackageImports`.

Turbopack counterpart: vercel/turbo#7731

### Why?

Some packages like `@tremor/react` causes a problem without `optimizePackageImports`.

### How?

Closes PACK-2527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees

@kdy1 kdy1

Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdy1 @sokra