feat(telemetry): add JS package #7820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
|
✅ This change can build |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
tknickman
force-pushed
the
tomknickman/turbo-2686-port-telemetry-crate-to-js
branch
from
a90ae13
to
2f5cf3b
Compare
🟢 CI successful 🟢Thanks |
tknickman
force-pushed
the
tomknickman/turbo-2686-port-telemetry-crate-to-js
branch
from
2f5cf3b
to
dd3ff0d
Compare
mehulkar
reviewed
Mar 25, 2024
tknickman
force-pushed
the
tomknickman/turbo-2686-port-telemetry-crate-to-js
branch
from
dd3ff0d
to
55f289c
Compare
chris-olszewski
approved these changes
Mar 26, 2024
tknickman
force-pushed
the
tomknickman/turbo-2686-port-telemetry-crate-to-js
branch
from
55f289c
to
b138c2e
Compare
|
@chris-olszewski the intention isn't to mirror events here one to one, but for the events tracked in the JS packages to be unique and specific to the JS packages. These also use a different event type on the backend that always tracks the package name and version as context. I did think about napi for some of the shared code (like config) but the lift was low and didn't want to deal with the multi os / arch support here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
turbo-telemetrylibrary that enables tracking telemetry events from javascript packages.Important
This shares all telemetry state with turbo core's telemetry. This means users only need to disable once across all packages.