refactor(turborepo): Bumping biome crates and moving to derive for deserialize #7875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @NicholasLYang and the rest of your teammates on |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
NicholasLYang
force-pushed
the
chore/bump-nightly
branch
from
dd3b49e
to
3985bdb
Compare
NicholasLYang
force-pushed
the
refactor/use-derive-for-deserializable
branch
from
b7f3bef
to
a6db7a8
Compare
🟢 CI successful 🟢Thanks |
NicholasLYang
force-pushed
the
chore/bump-nightly
branch
from
3985bdb
to
65f5017
Compare
NicholasLYang
force-pushed
the
refactor/use-derive-for-deserializable
branch
from
beffe28
to
01edaf8
Compare
NicholasLYang
force-pushed
the
refactor/use-derive-for-deserializable
branch
from
01edaf8
to
83c9b29
Compare
NicholasLYang
changed the title
NicholasLYang
commented
Apr 5, 2024
| #[serde(rename_all = "camelCase")] | ||
| pub struct SpacesJson { | ||
| pub id: Option<UnescapedString>, | ||
| #[serde(flatten)] | ||
| pub other: Option<serde_json::Value>, |
There was a problem hiding this comment.
I don't see this being used anywhere?
| text: Option<Arc<str>>, | ||
| #[serde(skip)] | ||
| path: Option<Arc<str>>, | ||
| span: Spanned<()>, |
There was a problem hiding this comment.
Had to change this because previous types wouldn't work well with derive.
| #[serde(skip_serializing_if = "Spanned::is_none")] | ||
| cache: Spanned<Option<bool>>, | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| cache: Option<Spanned<bool>>, |
There was a problem hiding this comment.
Same as above. Plays well with derive
| @@ -802,6 +804,7 @@ mod tests { | |||
| &root_package_json, | |||
| false, | |||
| )?; | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
|
|
||
| struct ConfigurationOptionsVisitor; | ||
|
|
||
| impl DeserializationVisitor for ConfigurationOptionsVisitor { |
There was a problem hiding this comment.
Turns out we don't ever even use this!
tknickman
approved these changes
Apr 11, 2024
| @@ -199,7 +199,7 @@ mod tests { | |||
|
|
|||
| #[test_case(Spanned { value: 10, range: Some(0..2), path: None, text: None }, "10")] | |||
| #[test_case(Spanned { value: "hello world", range: None, path: None, text: Some(Arc::from("hello world")) }, "\"hello world\"")] | |||
| #[test_case(Spanned { value: json!({ "name": "George", "age": 100 }), range: None, path: None, text: Some(Arc::from("hello world")) }, "{\"age\":100,\"name\":\"George\"}")] | |||
| #[test_case(Spanned { value: json!({ "name": "George", "age": 100 }), range: None, path: None, text: Some(Arc::from("hello world")) }, "{\"name\":\"George\",\"age\":100}")] | |||
NicholasLYang
force-pushed
the
refactor/use-derive-for-deserializable
branch
from
f66be69
to
841ad0f
Compare
NicholasLYang
force-pushed
the
refactor/use-derive-for-deserializable
branch
from
841ad0f
to
9d035d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Biome shipped a new derive for their
Deserializabletrait. This saves us from having to manually implement the trait, barring a few exceptions.Testing Instructions
Closes TURBO-2740